-
Notifications
You must be signed in to change notification settings - Fork 14
Fluxnet and global run documentation #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e62762d
to
3a03605
Compare
I don't completely understand how we read in the fluxnet forcing. We can have periodic BCs if we use the TVI constructor we use for |
1b8f227
to
18f63f5
Compare
I wasnt sure because when I worked on this the |
6f7648f
to
a255721
Compare
docs/src/tutorials/standalone/Canopy/changing_canopy_parameterizations.jl
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a dramatic improvement of ClimaLand documentation, thank you Kat!
I left a bunch of comments below, I don't think we need to address them all in this PR, I leave it up to you.
I can go through another review later on today if needed, let me know when you think it is ready to merge!
Note: the getting_started.md page (not modified in this PR) has a typo, we could correct it here. Line 17, "journet" instead of "journey".
In getting_started.md, there's an error due to "About.jl" not being installed. I know we removed it a while ago because of a bug. Maybe it's been fixed now? (I can do this in another PR)
the getting_started.md page is called "running your first simulation" yet doesn't have code to run a simulation (also for another PR maybe - I thought Julia had a PR for it but I can't find it anymore)
The file structure in the code doesn't match the menu structure of the docs. it makes it a bit hard to navigate.
docs menu:
docs code:
The page changing_canopy_parameterizations
is empty
Maybe we don't want to show the output (or silence warning) of some box of code, e.g., running fluxnet simulations:
Note this seems quite important - some box of warnings are very long... (if needed I can help with this)
The driver_tutorial
page has a long return box that should be hidden
Can we rename "Leaderboard" to "Benchmark"? Benchmark is a well known modelling exercise, to compare model output to observation. Leaderboard is more an internal CliMA goal of showing we're the best model...
Note: I see that Kevin added warning boxes in the calibration docs. I think this is pretty neat and we should use it throughout the docs

APIs/shared_utilities, simulations, has a blank name (-) (which should be "LandSimulations" I believe)
APIs/Soil_Albedo rendering is bugged. It seems to be full of titles (hashtags)
"Shared utilities" => "shared_utilities.md", | ||
], | ||
"Physical units" => "physical_units.md", | ||
"Julia background" => "julia.md", | ||
"APIs" => apis, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new make_set_fluxnet_initial_conditions
is much cleaner than defining it is the simulation script!
I left a few comments, mostly about the assumption that start_date = t0.epoch
(which is almost always the case).
3c6b2c6
to
67625e7
Compare
67625e7
to
ed30c1a
Compare
I had the same HTTP error in the ubuntu tests - I retried and it ran ok |
Purpose
Improve documentation for fluxnet and global runs; simplify table of contents in docs
preview: https://clima.github.io/ClimaLand.jl/previews/PR1288/
Bucket Plots:
bucket_figures.pdf
bucket_annual_timeseries.pdf
Snow land fluxnet:
US_NR1_variable_timeseries.pdf
US_NR1_diurnal_timeseries.pdf
Soil canopy
US_MOz_diurnal_timeseries.pdf
To-do
Future PRs
- Change default plotting to png - otherwise we cannot show pdf in doc markdown
Content
docs:
To review: @juliasloan25 all docs/ changes and src/integrated/soil_canopy_model.jl
@AlexisRenchon all docs/ changes and src/integrated/soil_canopy_model.jl
fluxnet and simulations:
Moved to PR 1315:
-test/integrated/full_land_utils.jl