Conversation
…ean.jl into ss/sea-ice-momentum-stress
|
|
||
| # Remember to pass the SSS as a bottom bc to the sea ice! | ||
| SSS = view(ocean.model.tracers.S, :, :, grid.Nz) | ||
| SSS = view(ocean.model.tracers.S.data, :, :, grid.Nz) |
There was a problem hiding this comment.
does this stand for "sea surface salinity"?
src/DataWrangling/JRA55/JRA55.jl
Outdated
| module JRA55 | ||
|
|
||
| export JRA55FieldTimeSeries, JRA55PrescribedAtmosphere, JRA55RepeatYear | ||
| export JRA55FieldTimeSeries, JRA55PrescribedAtmosphere, JRA55RepeatYear, JRA55MultipleYears |
There was a problem hiding this comment.
Do we like this or
- RepeatYearJRA55
- MultiYearJRA55
the latter is how we say it out loud
There was a problem hiding this comment.
I'm not oppposted to "multi-year" rather than "multiple years" because "multi-year" is how we pronounce it
|
@navidcy @simone-silvestri which do you like more? option 1
option 2
option 3
or something else? I like option 3 because it's how I say it out loud. |
|
There is also
? This is not as explicit. Implies that if nothing is said then JRA55 means the JRA55 full deal? |
|
From what you suggested I prefer option 3, 2, 1. In this order. |
| SSS = view(ocean.model.tracers.S.data, :, :, grid.Nz) | ||
| bottom_heat_boundary_condition = IceWaterThermalEquilibrium(SSS) |
There was a problem hiding this comment.
So the bottom_heat_boundary_condition is time-varying as sea-surface salinity changes?
There was a problem hiding this comment.
have we thought about restoring the surface salinity?
that's commonly done and, as far as I know, needed to avoid model drifting; see 4th paragraph in section 2.3 in the ACCESS-OM2 paper
There was a problem hiding this comment.
I was thinking to leave it out for the moment.
There was a problem hiding this comment.
gotcha! no worries, I just wanted to ensure we remember this. I'm told that without SSS restoring there is often lot of drift in the models. We can keep that in mind.
| ##### | ||
|
|
||
| omip = OceanSeaIceModel(ocean, sea_ice; atmosphere, radiation) | ||
| omip = Simulation(arctic, Δt=1minutes, stop_time=30days) |
There was a problem hiding this comment.
I guess it not arctic but omip? there is a re-definition in this line then? omip above is a coupled model and here it becomes a simulation of coupled model?
There was a problem hiding this comment.
right, I will push the new script
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
I prefer option 2 cause I like the JRA55 at the beginning, but I am not opposed to option 3. I will Implement this in #437 |
5 participants
A PR that will introduce the pieces of an OMIP prototype. requires #437 and #453