Skip to content

Conversation

@glwagner
Copy link
Member

This piece of code continues to cause lots of issues so I am removing it. #477 will take up the mantle of a better smoothing method.

@navidcy
Copy link
Member

navidcy commented May 1, 2025

Test fail. :(

@glwagner
Copy link
Member Author

glwagner commented May 1, 2025

The test failure is in the category "Availability of bathymetry" which doesn't make sense https://buildkite.com/clima/climaocean-ci/builds/3801#01968909-6062-4ff2-a01b-27a266982771/184-641

@navidcy
Copy link
Member

navidcy commented May 1, 2025

@glwagner
Copy link
Member Author

glwagner commented May 1, 2025

Not sure but we should consider moving all GPU tests to tartarus...

@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.23%. Comparing base (955e464) to head (a23e2e7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Bathymetry.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
- Coverage   27.25%   27.23%   -0.03%     
==========================================
  Files          47       47              
  Lines        2814     2798      -16     
==========================================
- Hits          767      762       -5     
+ Misses       2047     2036      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simone-silvestri simone-silvestri merged commit b79de11 into main May 16, 2025
23 of 26 checks passed
@simone-silvestri simone-silvestri deleted the glw/always-pass branch May 16, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants