Skip to content

Fix mistake in EdsonMomentumStabilityFunctions #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025
Merged

Fix mistake in EdsonMomentumStabilityFunctions #503

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
843961e
Fix mistake in EdsonMomentumStabilityFunctions
navidcy May 7, 2025
494b071
Merge branch 'main' into ss-ncc/fix-edson-momentum-stability-function
simone-silvestri May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/OceanSeaIceModels/InterfaceComputations/similarity_theory_turbulent_fluxes.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ These stability functions are obtained by regression to experimental data.
The stability parameter for stable atmospheric conditions is defined as
```math
dζ = min(ζmax, Aˢζ)
ψₛ = - (Bˢ ζ + Cˢ ( ζ - Dˢ ) ) exp( - dζ) - Cˢ Dˢ
ψₛ = - Bˢ * ζ⁺ - Cˢ * (ζ⁺ - Dˢ) * exp(- dζ) - Cˢ * Dˢ
```

While the stability parameter for unstable atmospheric conditions is calculated
Expand Down Expand Up @@ -329,7 +329,7 @@ end
dζ = min(ζmax, Aˢ * ζ⁺)

# Stability parameter for _stable_ atmospheric conditions
ψₛ = - (Bˢ * ζ⁺ + Cˢ * (ζ⁺ - Dˢ)) * exp(- dζ) - Cˢ * Dˢ
ψₛ = - Bˢ * ζ⁺ - Cˢ * (ζ⁺ - Dˢ) * exp(- dζ) - Cˢ * Dˢ

# Stability parameter for _unstable_ atmospheric conditions
fᵤ₁ = sqrt(sqrt(1 - Aᵘ * ζ⁻))
Expand Down
Loading