Draft
Conversation
…into ss/multi-year-JRA55
…ean.jl into ss/sea-ice-momentum-stress
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Member
|
Should we replace the one-degree example with this one? |
glwagner
reviewed
Oct 13, 2025
| 5. Possibly, additional "bulk" properties of the surface media and radiation fluxes | ||
| in order to compute an equilibrium "skin" surface temperature that differs from the | ||
| bulk temperature below the surface. | ||
|
|
glwagner
reviewed
Oct 13, 2025
| z_faces = ExponentialDiscretization(Nz, -6000, 0; scale=1800) | ||
|
|
||
| const z_surf = z_faces.cᵃᵃᶠ(Nz) | ||
| const z_surf = z_faces(Nz) |
Collaborator
Author
There was a problem hiding this comment.
I guess because it's used in a function later?
@inline mask(x, y, z, t) = z ≥ z_surf - 1
…emove 20-year run script
glwagner
reviewed
Oct 14, 2025
Comment on lines
+4
to
+12
| using Oceananigans.Grids | ||
| using Oceananigans.Units | ||
| using Oceananigans.OrthogonalSphericalShellGrids | ||
| using Oceananigans.BuoyancyFormulations: buoyancy, buoyancy_frequency | ||
| using ClimaOcean.OceanSimulations | ||
| using ClimaOcean.ECCO | ||
| using ClimaOcean.JRA55 | ||
| using ClimaOcean.DataWrangling | ||
| using ClimaSeaIce.SeaIceThermodynamics: IceWaterThermalEquilibrium |
Member
There was a problem hiding this comment.
Suggested change
| using Oceananigans.Grids | |
| using Oceananigans.Units | |
| using Oceananigans.OrthogonalSphericalShellGrids | |
| using Oceananigans.BuoyancyFormulations: buoyancy, buoyancy_frequency | |
| using ClimaOcean.OceanSimulations | |
| using ClimaOcean.ECCO | |
| using ClimaOcean.JRA55 | |
| using ClimaOcean.DataWrangling | |
| using ClimaSeaIce.SeaIceThermodynamics: IceWaterThermalEquilibrium | |
| using Oceananigans.Units |
…ing and output configuration
…aset to EN4Monthly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to develop a half-degree global simulation with GM closure