Fix default float to Oceananigans.defaults.FloatType#112
Merged
simone-silvestri merged 3 commits intomainfrom Feb 4, 2026
Merged
Fix default float to Oceananigans.defaults.FloatType#112simone-silvestri merged 3 commits intomainfrom
Oceananigans.defaults.FloatType#112simone-silvestri merged 3 commits intomainfrom
Conversation
juliasloan25
approved these changes
Feb 4, 2026
Member
juliasloan25
left a comment
juliasloan25
left a comment
There was a problem hiding this comment.
This looks good to me. The only place I see Float64 left in src is in EnthalpyMethodSeaIceModel.jl. I'm not sure if that would affect our CMIP runs
Collaborator
Author
|
nono, for the coupled runs we use the |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClimaSeaIce currently uses
Float64as default for constructors, this PR changes the defaults toOceananigans.defaults.FloatTypecloses #111