Skip to content

Antarctic slope current example #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 50 commits into
base: main
Choose a base branch
from
Open

Antarctic slope current example #8

Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
02b697c
Set up grid with immersed boundary condition for ASC model, starting …
jlk9 Jul 5, 2023
3f7b23a
Adding sponge layers and coriolis, updated equations of state to be h…
jlk9 Jul 5, 2023
375b630
Added both sponge layers and relaxation forcings, and diffusivities a…
jlk9 Jul 5, 2023
2e28ce6
Created simulation run
jlk9 Jul 6, 2023
952b796
Fixed simulation time scale, set to run on GPU
jlk9 Jul 6, 2023
17da147
Printing out simulation
Jul 7, 2023
2c2cfea
Adding storage of output
jlk9 Jul 7, 2023
f7ae29f
Minor edits
Jul 7, 2023
8e27b2a
Update examples/antarctic_slope_current_model.jl
jlk9 Jul 10, 2023
528c194
Update examples/antarctic_slope_current_model.jl
jlk9 Jul 10, 2023
9656960
Update examples/antarctic_slope_current_model.jl
jlk9 Jul 10, 2023
ba3f10a
Update examples/antarctic_slope_current_model.jl
jlk9 Jul 10, 2023
1518f01
Update examples/antarctic_slope_current_model.jl
jlk9 Jul 10, 2023
9eeebf2
Update examples/antarctic_slope_current_model.jl
jlk9 Jul 10, 2023
fed4167
Update examples/antarctic_slope_current_model.jl
jlk9 Jul 10, 2023
9fb7d9f
Update examples/antarctic_slope_current_model.jl
jlk9 Jul 10, 2023
432b51f
Update examples/antarctic_slope_current_model.jl
jlk9 Jul 10, 2023
5ae2bb0
Update examples/antarctic_slope_current_model.jl
jlk9 Jul 10, 2023
c7ee0f7
Adding some modules for new changes
jlk9 Jul 10, 2023
9035fcd
Created low-resolution model run that generates movie of model variab…
jlk9 Jul 13, 2023
8a216e8
Modified script for 5 day run
jlk9 Jul 14, 2023
90bb0f4
Added wind stress as a surface boundary condition
jlk9 Jul 19, 2023
9a26cb1
Added zonal average cross-section visualization
jlk9 Jul 21, 2023
788e573
Running with larger step size
jlk9 Jul 26, 2023
9836e44
Using smaller vertical stratification
jlk9 Jul 27, 2023
bb40c83
Minor edit
jlk9 Jul 27, 2023
c70a2ff
Minor edit
jlk9 Jul 27, 2023
820941e
Minor edit
jlk9 Jul 27, 2023
1650072
Running more tests
jlk9 Jul 28, 2023
0b43b1e
Trying hi-res model with custom beta plane
jlk9 Aug 2, 2023
3e25a6a
Testing different runs
jlk9 Aug 15, 2023
380708d
Added wind stress and relaxation sponge layers
jlk9 Aug 21, 2023
12a133e
Added speed data and plots
jlk9 Aug 23, 2023
cf94e3e
minor adds
jlk9 Aug 23, 2023
31d1748
Fixed boundary condition implementation
jlk9 Aug 24, 2023
aaf894c
Changed filename
jlk9 Aug 24, 2023
5cec281
Can now run full workflow remotely
Oct 20, 2023
72c7b05
Merge branch 'main' into asc_model_example
Oct 20, 2023
35181a6
Trying relaxation on boundaries again
jlk9 Oct 20, 2023
cc71c6f
Removed relaxation forcing
Oct 23, 2023
8fe96d1
Add sea ice package
Oct 31, 2023
9d590d8
Adding architecture field to SlabIceModel
jlk9 Oct 31, 2023
fc13b51
Cleaning up architecture field
jlk9 Oct 31, 2023
a15fc56
Still fixing grid architecture field
jlk9 Oct 31, 2023
e59a723
Adding architecture field to ice_ocean_model struct
jlk9 Oct 31, 2023
2b1196e
Add AbstractArchitecture
jlk9 Oct 31, 2023
1c5790f
Set up model run with ice
jlk9 Nov 1, 2023
10c77ff
Updated ice-ocean model, added architecture functions to SlabSeaIceMo…
jlk9 Nov 8, 2023
4d6be26
Added architecture functions to OceanIceModel
jlk9 Nov 8, 2023
64aa547
Fixed vorticity plot, added heat flux computations back in
jlk9 Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/SlabSeaIceModels/slab_sea_ice_model.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ struct SlabSeaIceModel{GR, CL, TS, IT, IC, ST, IS, U, STF, TBC, CF, P, MIT, A} <
ice_consolidation_thickness :: MIT
# Numerics
advection :: A
architecture
Copy link
Member

@glwagner glwagner Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
architecture
architecture :: Arch

This needs a type parameter to be concrete

but you should be able to get the architecture from the grid?

end

const SSIM = SlabSeaIceModel
Expand Down Expand Up @@ -156,6 +157,8 @@ function SlabSeaIceModel(grid;
heat_boundary_conditions = (top = top_heat_boundary_condition,
bottom = bottom_heat_boundary_condition)

architecture = architecture(grid)

return SlabSeaIceModel(grid,
clock,
timestepper,
Expand All @@ -169,7 +172,8 @@ function SlabSeaIceModel(grid;
internal_heat_flux_function,
phase_transitions,
ice_consolidation_thickness,
advection)
advection,
architecture)
end

function set!(model::SSIM; h=nothing, α=nothing)
Expand Down