Speeding up Dynamics and removing internal heat flux when h < hc#89
Merged
simone-silvestri merged 37 commits intomainfrom Sep 3, 2025
Merged
Speeding up Dynamics and removing internal heat flux when h < hc#89simone-silvestri merged 37 commits intomainfrom
h < hc#89simone-silvestri merged 37 commits intomainfrom
Conversation
navidcy
reviewed
Aug 21, 2025
navidcy
reviewed
Aug 21, 2025
navidcy
reviewed
Aug 21, 2025
navidcy
approved these changes
Aug 21, 2025
Member
navidcy
left a comment
There was a problem hiding this comment.
@simone-silvestri could you update the PR title/first post to reflect the changes done here? Happy to merge otherwise!
navidcy
reviewed
Aug 21, 2025
Collaborator
Author
Added a description, we need to wait for CliMA/Oceananigans.jl#4706 though before merging this one. |
h < hc
Collaborator
Author
|
I think this should be ready to merge once a new version of Oceananigans is released. |
Member
|
If it requires Oceananigans v0.98 then we should edit the compat requirements |
…to ss/omip-branch-2
…to ss/omip-branch-2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch used for the OMIP simulations in ClimaOcean. No need to merge. Just to document what is being done.
When the OMIP is stable and running we can start decomposing the bits and pieces of this branch into different PRs.
Speeding up (quite considerably)
SeaIceDynamicsThis branch deals with the efficient execution of the sea ice dynamics in split form. Many small kernels need to be launched, so this PR ensures that:
mask_immersed_field_xy!for example, but zeroing out the velocity in peripheral regions directly in the kernels)To achieve this, the auxiliaries of a particular rheology are divided into
auxiliaries.fieldsandauxiliaries.kernelsfor theElastoViscoPlasticRheologywhereauxiliaries.kernelshold the preconfigured kernels to compute viscosity and stresses.Note!!! this branch requires CliMA/Oceananigans.jl#4706 to be efficient and work properly, since we are passing converted arguments to the
fill_halo_regions!function, which is not possible prior to 4706, that refactors how fill halos work by saving down preconfigured kernels.No internal heat flux if the ice is not consolidated
This PR also removes the internal heat flux if the sea ice is unconsolidated to avoid very large internal heat flux values. This was already done for all top boundary conditions except for a
PrescribedTemperaturetop boundary condition which is the one we use in ClimaOcean.jl