Change TVI0d constructor to conditionally promote #187
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph-kev
reviewed
Aug 22, 2025
ext/TimeVaryingInputs0DExt.jl
Outdated
Comment on lines
112
to
113
| t0 = times[begin] | ||
| if !(isnothing(t0.epoch) || all(t -> t.epoch == t0.epoch, times)) |
There was a problem hiding this comment.
Maybe I am missing it, but if the first ITime doesn't have an epoch, you wouldn't want to call promote?
There was a problem hiding this comment.
Also, I prefer first(times) over times[begin].
There was a problem hiding this comment.
The parenthesis make this petty unclear. Line 113 should be equivalent to
if (!isnothing(t0.epoch) && (!all(t -> t.epoch == t0.epoch, times))
So it shouldn't promote if the first time does not have an epoch.
The changes I made here could be incorrect because it assumes that all the ITimes have an epoch or do not, when the inout could be a mix.
imreddyTeja
force-pushed
the
tr/time-varying-promote
branch
from
df73c25 to
3208650
Compare
Promoting a large number of ITimes is expensive, so this modifies the behavior to only do so if needed. fixes
imreddyTeja
force-pushed
the
tr/time-varying-promote
branch
from
3208650 to
00ae122
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promoting a large number of ITimes is expensive, so this modifies the behavior to only do so if needed.
Closes #186