Skip to content

Conversation

@charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented May 31, 2025

This makes the following pattern easier:

∑tendencies = lazy.(∑tendencies .+ viscous_sponge_tendency_uₕ(ᶜuₕ, viscous_sponge)) as the result will return ∑tendencies directly. We can't easily broadcast on ∑tendencies if it's initialized with a scalar number.

@codecov
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 34.21%. Comparing base (0523c23) to head (d59da43).

Files with missing lines Patch % Lines
src/NullBroadcasts.jl 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   36.11%   34.21%   -1.91%     
==========================================
  Files           1        1              
  Lines          36       38       +2     
==========================================
  Hits           13       13              
- Misses         23       25       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charleskawczynski
Copy link
Member Author

charleskawczynski commented Jun 3, 2025

I really don't like this solution. The output type now depends on whether we write a .- (::NullBroadcasted) vs (::NullBroadcasted) .- a, which just seems bad. I think I'd rather do something more explicit, clunky and simple upstream.

@charleskawczynski charleskawczynski marked this pull request as draft June 3, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants