Skip to content

Bump compat entries for PencilFFTs and PencilArrays#3121

Merged
navidcy merged 4 commits intomainfrom
ncc/pencils
Jun 28, 2023
Merged

Bump compat entries for PencilFFTs and PencilArrays#3121
navidcy merged 4 commits intomainfrom
ncc/pencils

Conversation

@navidcy
Copy link
Member

@navidcy navidcy commented May 25, 2023

Supercedes #3119 #3120

@navidcy navidcy added package 📦 Quite meta distributed 🕸️ Our plan for total cluster domination labels May 25, 2023
@glwagner
Copy link
Member

Do these support CuArray?

@navidcy
Copy link
Member Author

navidcy commented Jun 27, 2023

Think so. GPU tests passed, only docs are failing now (but I think they just failed to start... I'm restarting!)

@navidcy navidcy merged commit c98d7aa into main Jun 28, 2023
@navidcy navidcy deleted the ncc/pencils branch June 28, 2023 04:35
@glwagner
Copy link
Member

I don't think we use PencilArray for CuArray either in the source code or tests. My question is: does bumping PencilArrays and PencilFFTs mean that we can extend the distributed FFT algorithm (currently only implemented on CPU) to GPUs?

@navidcy
Copy link
Member Author

navidcy commented Jun 29, 2023

Oh I see. This was not at all clear to me from your previous question. I thought you were asking whether the new versions dropped support to CuArrays and therefore explain why tests were failing!

Let me get back on your question now that I understand!

@navidcy
Copy link
Member Author

navidcy commented Jun 29, 2023

I doubt it... I understood that the main change in the packages is jipolanco/PencilFFTs.jl#65. Nothing mentioned for CuArrays...

@navidcy
Copy link
Member Author

navidcy commented Jun 29, 2023

But then this issue (jipolanco/PencilFFTs.jl#56) implies that already these packages work for GPUs over distributed. No?

@glwagner
Copy link
Member

Yes, I think they do. I was wondering if the update here brought in that change (another possibility is that it's already supported)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

distributed 🕸️ Our plan for total cluster domination package 📦 Quite meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants