Skip to content

Conversation

@navidcy
Copy link
Member

@navidcy navidcy commented Oct 15, 2025

Perhaps this is related to those weird MultiRegion-related methods appearing with Distributed? See CliMA/ClimaOcean.jl#647 (comment)

Since the method wasn't imported, the attempt below to extent it might resulted in overwriting it?

What was missing was:

import Oceananigans.BoundaryConditions: FieldBoundaryConditions

Julia v1.12 warned me for that; that's how I found it.

  1 dependency had output during precompilation:
┌ Oceananigans
│  WARNING: Constructor for type "FieldBoundaryConditions" was extended in `MultiRegion` without explicit qualification or import.
│    NOTE: Assumed "FieldBoundaryConditions" refers to `BoundaryConditions.FieldBoundaryConditions`. This behavior is deprecated and may differ in future versions.`
│    NOTE: This behavior may have differed in Julia versions prior to 1.12.
│    Hint: If you intended to create a new generic function of the same name, use `function FieldBoundaryConditions end`.
│    Hint: To silence the warning, qualify `FieldBoundaryConditions` as `BoundaryConditions.FieldBoundaryConditions` in the method signature or explicitly `import BoundaryConditions: FieldBoundaryConditions`.

cc @taimoorsohail

navidcy referenced this pull request Oct 15, 2025
…structure updates (#4538)

* Make necessary modifications

* Update multi_region_split_explicit_free_surface.jl

* Fix bug

* Update src/Utils/multi_region_transformation.jl

Co-authored-by: Navid C. Constantinou <[email protected]>

* Update src/Models/HydrostaticFreeSurfaceModels/pcg_implicit_free_surface_solver.jl

Co-authored-by: Simone Silvestri <[email protected]>

* Fix bug

* Compact code

* Specialize difference operators for CCSPanelGrid

* Fix bug

* Extend tupled_fill_halo_regions!

* Fix bug

* Remove replace_horizontal_vector_halos!

* Add explanatory comments and fix bug

* Update src/Models/HydrostaticFreeSurfaceModels/pcg_implicit_free_surface_solver.jl

Co-authored-by: Simone Silvestri <[email protected]>

* Update src/Models/HydrostaticFreeSurfaceModels/pcg_implicit_free_surface_solver.jl

Co-authored-by: Simone Silvestri <[email protected]>

* Update src/MultiRegion/unified_implicit_free_surface_solver.jl

Co-authored-by: Simone Silvestri <[email protected]>

* Fix bug

* Remove auxiliary_actions!

* Fix bugs

* Update src/Models/HydrostaticFreeSurfaceModels/update_hydrostatic_free_surface_model_state.jl

* comment the todo

* FieldBoundaryBuffers --> CommunicationBuffers

* Remove unused parameter in fill_halo_size function

* Fix bug

* Remove hardcoded situation-specific logic

* Incorporate modifications from PR #4566

* Incorporate modifications from PR #4568

* Fix typo

* Enhance code

* Reinstate unused parameter for consistency

* Fix out-of-bounds memory access bug

* Fix typo

* Fix bug

* Remove commented-out line

* Fix typo

* Fix bug

* correct getregion for an immersed boundary grid

* fix show for a multiregion grid

* active cells map for CSG

* add a small test for IBG construction on CSG

* including Immersed boundary grids in the PCG solver

* Fix out-of-bounds memory allocation error

* Update test_multi_region_cubed_sphere.jl

* Use ConformalCubedSphereGridOfSomeKind

* Fix out-of-bounds error

* Update test_multi_region_cubed_sphere.jl

* Fix out-of-bounds error

* Update test_multi_region_cubed_sphere.jl

* Leverage reduced_dimensions for kernel launches

* add a function inside apply regionally

* Enhance code

* Compact code

* switch the apply regionally inside the linear operation

* revert

* Update src/MultiRegion/multi_region_split_explicit_free_surface.jl

* Update src/MultiRegion/multi_region_boundary_conditions.jl

* Update src/MultiRegion/multi_region_boundary_conditions.jl

* Fix GPU error

* Define ConformalCubedSpherePanelGridOfSomeKind

* Fix GPU kernel type instability bug

---------

Co-authored-by: Navid C. Constantinou <[email protected]>
Co-authored-by: Simone Silvestri <[email protected]>
@navidcy navidcy requested a review from taimoorsohail October 15, 2025 22:48
@taimoorsohail
Copy link
Collaborator

The error persists with your first tranche of changes @navidcy

@navidcy
Copy link
Member Author

navidcy commented Oct 16, 2025

hm... I still think this PR resolves a mistake.
I'll wait for @simone-silvestri or @siddharthabishnu to confirm

@simone-silvestri
Copy link
Collaborator

simone-silvestri commented Oct 16, 2025

indeed, it does solve an issue (we had that change in #4760)

@navidcy navidcy merged commit 5eec6fe into main Oct 16, 2025
69 checks passed
@navidcy navidcy deleted the ncc/add-missing-import branch October 16, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants