- 
                Notifications
    You must be signed in to change notification settings 
- Fork 250
          Add missing import when extending FieldBoundaryConditions in MultiRegion
          #4860
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
    
  navidcy 
      referenced
      this pull request
    
      Oct 15, 2025 
    
    
      
  
    
      
    
  
…structure updates (#4538) * Make necessary modifications * Update multi_region_split_explicit_free_surface.jl * Fix bug * Update src/Utils/multi_region_transformation.jl Co-authored-by: Navid C. Constantinou <[email protected]> * Update src/Models/HydrostaticFreeSurfaceModels/pcg_implicit_free_surface_solver.jl Co-authored-by: Simone Silvestri <[email protected]> * Fix bug * Compact code * Specialize difference operators for CCSPanelGrid * Fix bug * Extend tupled_fill_halo_regions! * Fix bug * Remove replace_horizontal_vector_halos! * Add explanatory comments and fix bug * Update src/Models/HydrostaticFreeSurfaceModels/pcg_implicit_free_surface_solver.jl Co-authored-by: Simone Silvestri <[email protected]> * Update src/Models/HydrostaticFreeSurfaceModels/pcg_implicit_free_surface_solver.jl Co-authored-by: Simone Silvestri <[email protected]> * Update src/MultiRegion/unified_implicit_free_surface_solver.jl Co-authored-by: Simone Silvestri <[email protected]> * Fix bug * Remove auxiliary_actions! * Fix bugs * Update src/Models/HydrostaticFreeSurfaceModels/update_hydrostatic_free_surface_model_state.jl * comment the todo * FieldBoundaryBuffers --> CommunicationBuffers * Remove unused parameter in fill_halo_size function * Fix bug * Remove hardcoded situation-specific logic * Incorporate modifications from PR #4566 * Incorporate modifications from PR #4568 * Fix typo * Enhance code * Reinstate unused parameter for consistency * Fix out-of-bounds memory access bug * Fix typo * Fix bug * Remove commented-out line * Fix typo * Fix bug * correct getregion for an immersed boundary grid * fix show for a multiregion grid * active cells map for CSG * add a small test for IBG construction on CSG * including Immersed boundary grids in the PCG solver * Fix out-of-bounds memory allocation error * Update test_multi_region_cubed_sphere.jl * Use ConformalCubedSphereGridOfSomeKind * Fix out-of-bounds error * Update test_multi_region_cubed_sphere.jl * Fix out-of-bounds error * Update test_multi_region_cubed_sphere.jl * Leverage reduced_dimensions for kernel launches * add a function inside apply regionally * Enhance code * Compact code * switch the apply regionally inside the linear operation * revert * Update src/MultiRegion/multi_region_split_explicit_free_surface.jl * Update src/MultiRegion/multi_region_boundary_conditions.jl * Update src/MultiRegion/multi_region_boundary_conditions.jl * Fix GPU error * Define ConformalCubedSpherePanelGridOfSomeKind * Fix GPU kernel type instability bug --------- Co-authored-by: Navid C. Constantinou <[email protected]> Co-authored-by: Simone Silvestri <[email protected]>
              
                    taimoorsohail
  
              
              approved these changes
              
                  
                    Oct 15, 2025 
                  
              
              
            
            
| The error persists with your first tranche of changes @navidcy | 
| hm... I still think this PR resolves a mistake. | 
| indeed, it does solve an issue (we had that change in #4760) | 
              
                    simone-silvestri
  
              
              approved these changes
              
                  
                    Oct 16, 2025 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Perhaps this is related to those weird MultiRegion-related methods appearing with Distributed? See CliMA/ClimaOcean.jl#647 (comment)
Since the method wasn't imported, the attempt below to extent it might resulted in overwriting it?
What was missing was:
Julia v1.12 warned me for that; that's how I found it.
cc @taimoorsohail