Enhance simulation docstring time step argument options + add prettytime(::AbstractTime) methods
#4887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for Dates.Period in time step argument.
Member
|
my review was requested, but so far the PR only changes the docstring. Intended? |
Member
Author
|
I requested it before we discussed about further changed on Simulations. |
Member
|
I'm willing to pick this up but I can't remember where we wanted to go with it. Can you remind me @navidcy ? |
Member
Author
|
I actually forgot... Perhaps we close it? Or merge as is? It's an improvement. I think our original intention was to document and improve the API for datetime clock? |
Member
|
we could merge as is, thats fine with me |
Member
Author
could you approve please? |
navidcy
changed the title
prettytime(::AbstractTime) methods
glwagner
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Dates.Period in time step argument.