Skip to content

Remove dependency on CUDA_Runtime_jll in test/ environment#5466

Merged
giordano merged 1 commit intomainfrom
mg/rm-cuda-runtime-jll
Apr 1, 2026
Merged

Remove dependency on CUDA_Runtime_jll in test/ environment#5466
giordano merged 1 commit intomainfrom
mg/rm-cuda-runtime-jll

Conversation

@giordano
Copy link
Copy Markdown
Collaborator

@giordano giordano commented Mar 31, 2026

Repeat of #4671. This was originally introduced in #3880 (comment), but I don't understand the motivation very well, might just be a problem which happened back then and has been resolved since. I removed this dependency in #5458, and tests still passed (all tests also passed in #4671). Close #5465

@giordano giordano added testing 🧪 Tests get priority in case of emergency evacuation package 📦 Quite meta labels Mar 31, 2026
@navidcy
Copy link
Copy Markdown
Member

navidcy commented Mar 31, 2026

I don't think the comment at the top will automatically close the #5465 (since it's a PR, not an issue). We'll just have to manually close that.

@giordano
Copy link
Copy Markdown
Collaborator Author

giordano commented Mar 31, 2026

It does work also with PRs. Example from yesterday: NumericalEarth/Breeze.jl#333 (comment)

@glwagner
Copy link
Copy Markdown
Member

I don't think the comment at the top will automatically close the #5465 (since it's a PR, not an issue). We'll just have to manually close that.

very bold to challenge @giordano on github mechanics

@navidcy
Copy link
Copy Markdown
Member

navidcy commented Apr 1, 2026

The AMDGPU tests are hanging (or in a long queue).
They seem irrelevant for this PR anyway.
Happy to merge!

@giordano giordano merged commit e369fb3 into main Apr 1, 2026
73 of 74 checks passed
@giordano giordano deleted the mg/rm-cuda-runtime-jll branch April 1, 2026 06:48
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.37%. Comparing base (b706e8f) to head (47d7769).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5466      +/-   ##
==========================================
- Coverage   73.77%   73.37%   -0.40%     
==========================================
  Files         400      400              
  Lines       22871    22871              
==========================================
- Hits        16872    16781      -91     
- Misses       5999     6090      +91     
Flag Coverage Δ
buildkite 68.94% <ø> (+<0.01%) ⬆️
julia 68.94% <ø> (+<0.01%) ⬆️
reactant_1 6.45% <ø> (?)
reactant_2 10.44% <ø> (ø)
reactant_3 9.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package 📦 Quite meta testing 🧪 Tests get priority in case of emergency evacuation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants