Remove dependency on CUDA_Runtime_jll in test/ environment#5466
Merged
Remove dependency on CUDA_Runtime_jll in test/ environment#5466
CUDA_Runtime_jll in test/ environment#5466Conversation
glwagner
approved these changes
Mar 31, 2026
navidcy
approved these changes
Mar 31, 2026
Member
|
I don't think the comment at the top will automatically close the #5465 (since it's a PR, not an issue). We'll just have to manually close that. |
Collaborator
Author
|
It does work also with PRs. Example from yesterday: NumericalEarth/Breeze.jl#333 (comment) |
Member
Member
|
The AMDGPU tests are hanging (or in a long queue). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5466 +/- ##
==========================================
- Coverage 73.77% 73.37% -0.40%
==========================================
Files 400 400
Lines 22871 22871
==========================================
- Hits 16872 16781 -91
- Misses 5999 6090 +91
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeat of #4671. This was originally introduced in #3880 (comment), but I don't understand the motivation very well, might just be a problem which happened back then and has been resolved since. I removed this dependency in #5458, and tests still passed (all tests also passed in #4671). Close #5465