Skip to content

Backward compatibility wrappers#296

Merged
tapios merged 2 commits intomainfrom
ts/backward-compat
Jan 11, 2026
Merged

Backward compatibility wrappers#296
tapios merged 2 commits intomainfrom
ts/backward-compat

Conversation

@tapios
Copy link
Member

@tapios tapios commented Jan 10, 2026

Adds wrappers with old function names for backward compatibility of ClimaAtmos, ClimaLand etc. with this version of Thermodynamics.jl

This PR may allow us to release this version of TD and then make the downstream changes, before removing the deprecated code.

@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.29%. Comparing base (02a6cd9) to head (2aa41b1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/depr_state_methods.jl 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
- Coverage   87.00%   86.29%   -0.72%     
==========================================
  Files          22       22              
  Lines        1093     1102       +9     
==========================================
  Hits          951      951              
- Misses        142      151       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tapios tapios requested a review from szy21 January 10, 2026 23:17
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm fine with not maintaining the backward compatibility though. I plan to update ClimaAtmos with the new Thermodynamics as soon as SurfaceFluxes is done.

@tapios
Copy link
Member Author

tapios commented Jan 11, 2026

Thanks. I'm fine with not maintaining the backward compatibility though. I plan to update ClimaAtmos with the new Thermodynamics as soon as SurfaceFluxes is done.

I thought this may allow us to work more piecemeal in the interim, working in atmos, coupler, land in sequence. I do want to delete these wrappers and other redundant code as soon as we can though.

@tapios tapios merged commit 979e344 into main Jan 11, 2026
15 of 17 checks passed
@tapios tapios deleted the ts/backward-compat branch January 11, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants