Fix method error when has_condensate has integer 0 input#299
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
==========================================
+ Coverage 86.45% 86.46% +0.01%
==========================================
Files 22 22
Lines 1115 1116 +1
==========================================
+ Hits 964 965 +1
Misses 151 151 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
szy21
approved these changes
Jan 13, 2026
Member
szy21
left a comment
There was a problem hiding this comment.
This is fine, but should we make the defaults FT(0) instead of Integer 0? Is it possible?
Member
Author
It's what @dennisYatunin said we should do to handle type promotion and duals seemlessly. I'll leave it for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a method to eps_numerics to avoid method errors when, for example,
relative_humidityis called without condensate arguments, leading to defaultq_liq = q_ice = 0(integer). This led to errors from has_condensate because the epsilon type inference was integer.