Skip to content

Fix method error when has_condensate has integer 0 input#299

Merged
tapios merged 1 commit intomainfrom
ts/method_error_patch
Jan 13, 2026
Merged

Fix method error when has_condensate has integer 0 input#299
tapios merged 1 commit intomainfrom
ts/method_error_patch

Conversation

@tapios
Copy link
Member

@tapios tapios commented Jan 13, 2026

Adds a method to eps_numerics to avoid method errors when, for example, relative_humidity is called without condensate arguments, leading to default q_liq = q_ice = 0 (integer). This led to errors from has_condensate because the epsilon type inference was integer.

@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.46%. Comparing base (50cde14) to head (898874a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   86.45%   86.46%   +0.01%     
==========================================
  Files          22       22              
  Lines        1115     1116       +1     
==========================================
+ Hits          964      965       +1     
  Misses        151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tapios tapios requested a review from szy21 January 13, 2026 07:15
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but should we make the defaults FT(0) instead of Integer 0? Is it possible?

@tapios
Copy link
Member Author

tapios commented Jan 13, 2026

This is fine, but should we make the defaults FT(0) instead of Integer 0? Is it possible?

It's what @dennisYatunin said we should do to handle type promotion and duals seemlessly. I'll leave it for now.

@tapios tapios merged commit e63280d into main Jan 13, 2026
17 checks passed
@tapios tapios deleted the ts/method_error_patch branch January 13, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants