Conversation
szy21
left a comment
There was a problem hiding this comment.
Could you change it for ::ph too? And I think you want tol = 0 instead of nothing? And given that it is with a fixed iteration, maybe we can return without converged, so we don't need those wrappers in ClimaAtmos?
|
Actually I think we should change the default in the convenience method, not the actual function. |
6150f3a to
9870f3b
Compare
da35602 to
200cbd4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
==========================================
- Coverage 87.37% 86.58% -0.79%
==========================================
Files 22 22
Lines 1156 1357 +201
==========================================
+ Hits 1010 1175 +165
- Misses 146 182 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
200cbd4 to
dedfecf
Compare
tapios
left a comment
There was a problem hiding this comment.
Looks good.
Consider reducing duplication by consolidating the fixed_iter functions into one function with methods for the variable combinations.
It would also be good to add tests for the derivatives (against finite differences) to ad_tests.jl.
d6c838d to
764eed1
Compare
6f81a2c to
dc450ce
Compare
No description provided.