Skip to content

Remove deprecated TD code; bump to v1.0#312

Merged
tapios merged 7 commits intomainfrom
ts/fully-functional-TD
Mar 9, 2026
Merged

Remove deprecated TD code; bump to v1.0#312
tapios merged 7 commits intomainfrom
ts/fully-functional-TD

Conversation

@tapios
Copy link
Member

@tapios tapios commented Mar 7, 2026

  • Removes deprecated code (e.g., thermodynamic states, a few redundant functions)
  • Updates docstrings for consistency
  • Adds a few tests
  • Bumps to v1.0
  • Removes redundant tol argument from fast saturation adjustment convenience function (closes Changes in next breaking release #310)

@tapios tapios requested a review from szy21 March 7, 2026 01:29
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.0! Are we sure there is no deprecated method used across CliMA repos?

@tapios
Copy link
Member Author

tapios commented Mar 7, 2026

v1.0! Are we sure there is no deprecated method used across CliMA repos?

Wow, that was too fast! Yes, I searched through the repos and fixed what I found (except in TurbulenceConvection and some older repos we no longer need).

@codecov
Copy link

codecov bot commented Mar 7, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.93%. Comparing base (56eb262) to head (9f64ef0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/air_saturation_functions.jl 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
+ Coverage   86.58%   87.93%   +1.34%     
==========================================
  Files          22       16       -6     
  Lines        1357      862     -495     
==========================================
- Hits         1175      758     -417     
+ Misses        182      104      -78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tapios tapios merged commit bfdc096 into main Mar 9, 2026
13 of 18 checks passed
@tapios tapios deleted the ts/fully-functional-TD branch March 9, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changes in next breaking release

2 participants