Skip to content

feat: add additionalManifests for arbitrary Kubernetes objects#196

Merged
dhable merged 4 commits intomainfrom
dan/hdx-3811-support-the-definition-of-additional-manifests
Mar 25, 2026
Merged

feat: add additionalManifests for arbitrary Kubernetes objects#196
dhable merged 4 commits intomainfrom
dan/hdx-3811-support-the-definition-of-additional-manifests

Conversation

@dhable
Copy link
Copy Markdown
Collaborator

@dhable dhable commented Mar 24, 2026

Summary

  • Add additionalManifests top-level value that accepts a list of arbitrary Kubernetes objects to deploy alongside the chart. Each entry is rendered through Helm's tpl function, giving access to chart helpers (e.g. clickstack.fullname, clickstack.labels) and .Values/.Release context.
  • Add helm-unittest test suite with 5 cases covering empty list, single manifest, multiple manifests, tpl expression evaluation, and ALB Ingress with controller-specific annotations.
  • Add docs/ADDITIONAL-MANIFESTS.md with full usage documentation including examples for ServiceAccount, NetworkPolicy, HPA, PodMonitor, AWS ALB Ingress, and TargetGroupBinding.
  • Add examples/alb-ingress/ with a ready-to-use values file for deploying ClickStack behind an AWS ALB.

Test plan

  • helm unittest charts/clickstack -- 25 suites, 151 tests passing
  • helm lint charts/clickstack -- 0 failures
  • helm template renders additionalManifests entries correctly alongside chart resources
  • Verify CI pipeline passes (helm-unittest + lint)

Made with Cursor

Allow users to deploy any Kubernetes resource (NetworkPolicy, HPA,
ServiceAccount, PodMonitor, ALB Ingress, etc.) alongside the chart
via a new `additionalManifests` values key. Each entry is rendered
through Helm's tpl function so chart helpers and .Values are available.

Made-with: Cursor
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 24, 2026

🦋 Changeset detected

Latest commit: a9d78f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
helm-charts Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dhable and others added 3 commits March 24, 2026 13:38
Clarify values-file templating constraints and replace non-parseable ALB/docs snippets so users can apply examples with -f directly. Add a Helm test workflow render check to prevent regressions in the ALB example values file.

Made-with: Cursor
Copy link
Copy Markdown
Collaborator

@wrn14897 wrn14897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@dhable dhable merged commit a615199 into main Mar 25, 2026
3 checks passed
@dhable dhable deleted the dan/hdx-3811-support-the-definition-of-additional-manifests branch March 25, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants