Skip to content

use remote mongodb #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wrn14897 merged 13 commits into from
Jun 5, 2025
Merged

use remote mongodb #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
71cc33e
use remote mongodb
OhJuhun Jun 4, 2025
b56a07c
fix pvc condition
OhJuhun Jun 4, 2025
c4c5bc3
add auth for mongo
OhJuhun Jun 4, 2025
e9a3e33
apply feedback
OhJuhun Jun 5, 2025
827c062
add changeset
OhJuhun Jun 5, 2025
9d0d447
remove if statement
OhJuhun Jun 5, 2025
3a72468
remove useless
OhJuhun Jun 5, 2025
ff040a6
Merge branch 'main' into use_remote_mongodb
OhJuhun Jun 5, 2025
75a533d
fix typo
OhJuhun Jun 5, 2025
c5e8a58
Merge branch 'use_remote_mongodb' of https://github.com/OhJuhun/helm-…
OhJuhun Jun 5, 2025
fad24d9
fix typo
OhJuhun Jun 5, 2025
73fb245
remove endl
OhJuhun Jun 5, 2025
866b8dd
Merge branch 'main' into use_remote_mongodb
wrn14897 Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/metal-queens-give.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"helm-charts": patch
---

enable using remote mongodb
2 changes: 1 addition & 1 deletion charts/hdx-oss-v2/templates/configmaps/app-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ data:
HYPERDX_APP_URL: "{{ .Values.hyperdx.appUrl }}"
HYPERDX_LOG_LEVEL: "{{ .Values.hyperdx.logLevel }}"
MINER_API_URL: "http://{{ include "hdx-oss.fullname" . }}-miner:5123"
MONGO_URI: "mongodb://{{ include "hdx-oss.fullname" . }}-mongodb:{{ .Values.mongodb.port }}/hyperdx"
MONGO_URI: "{{ tpl .Values.hyperdx.mongoUri . }}"
NEXT_PUBLIC_SERVER_URL: "http://localhost:{{ .Values.hyperdx.apiPort }}"
OTEL_SERVICE_NAME: "hdx-oss-api"
USAGE_STATS_ENABLED: "{{ .Values.hyperdx.usageStatsEnabled | default true }}"
Expand Down
2 changes: 2 additions & 0 deletions charts/hdx-oss-v2/templates/hyperdx-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@ spec:
{{- end -}}
{{- end }}
spec:
{{- if not .Values.mongodb.enabled }}
Copy link

@junzebao junzebao Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we enable mongodb, the initContainer is removed. Is the not here on purpose or accidental?

Copy link
Contributor Author

@OhJuhun OhJuhun Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@junzebao sorry. I missed this, and fixed here

initContainers:
- name: wait-for-mongodb
image: busybox
command: ['sh', '-c', 'until nc -z {{ include "hdx-oss.fullname" . }}-mongodb {{ .Values.mongodb.port }}; do echo waiting for mongodb; sleep 2; done;']
{{- end }}
containers:
- name: app
image: "{{ .Values.hyperdx.image }}"
Expand Down
1 change: 1 addition & 0 deletions charts/hdx-oss-v2/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ hyperdx:
usageStatsEnabled: true
# Endpoint to send hyperdx logs/traces/metrics to.Defaults to the chart's otel collector endpoint.
otelExporterEndpoint: http://{{ include "hdx-oss.fullname" . }}-otel-collector:{{ .Values.otel.httpPort }}
mongoUri: mongodb://{{ include "hdx-oss.fullname" . }}-mongodb:{{ .Values.mongodb.port }}/hyperdx
Copy link
Contributor Author

@OhJuhun OhJuhun Jun 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wrn14897 I think this doesn't work.

Copy link
Contributor Author

@OhJuhun OhJuhun Jun 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wrn14897
I think the best way to implement this is writing on _helpers.tpl. How do you think?
like this:

{{- define "hdx-oss.mongodb.uri" -}}
{{- if .Values.hyperdx.mongoUri -}}
    {{- printf .Values.hyperdx.mongoUri -}}
{{- else -}}
    {{- $mongodbPort := .Values.mongodb.port -}}
    {{- printf "mongodb://%s-mongodb:%d/hyperdx" (include "hdx-oss.fullname" .) ( $mongodbPort | int ) -}}
{{- end -}}
{{- end -}}

Copy link
Contributor Author

@OhJuhun OhJuhun Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wrn14897 sry. i missed write tpl. i fixed ignore this comments

annotations: {}
# myAnnotation: "myValue"
labels: {}
Expand Down