Skip to content

fix: rename CRON_IN_APP_DISABLED to RUN_SCHEDULED_TASKS_EXTERNALLY #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wrn14897 merged 3 commits into from
Jul 25, 2025
Merged

fix: rename CRON_IN_APP_DISABLED to RUN_SCHEDULED_TASKS_EXTERNALLY #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b83f05
fix: rename CRON_IN_APP_DISABLED to RUN_SCHEDULED_TASKS_EXTERNALLY
wrn14897 Jul 24, 2025
6697b78
ci: fix test
wrn14897 Jul 24, 2025
f73352d
docs: add changeset
wrn14897 Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/purple-mirrors-tell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"helm-charts": patch
---

fix: rename CRON_IN_APP_DISABLED to RUN_SCHEDULED_TASKS_EXTERNALLY
2 changes: 1 addition & 1 deletion charts/hdx-oss-v2/templates/configmaps/app-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ data:
MONGO_URI: "{{ tpl .Values.hyperdx.mongoUri . }}"
OTEL_SERVICE_NAME: "hdx-oss-api"
USAGE_STATS_ENABLED: "{{ .Values.hyperdx.usageStatsEnabled | default true }}"
CRON_IN_APP_DISABLED: "{{ .Values.tasks.enabled | default false }}"
RUN_SCHEDULED_TASKS_EXTERNALLY: "{{ .Values.tasks.enabled | default false }}"
OPAMP_PORT: "{{ .Values.hyperdx.opampPort }}"
OTEL_EXPORTER_OTLP_ENDPOINT: "{{ tpl .Values.hyperdx.otelExporterEndpoint . }}"
2 changes: 2 additions & 0 deletions charts/hdx-oss-v2/templates/cronjobs/task-checkAlerts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ spec:
value: "production"
- name: OTEL_SERVICE_NAME
value: "hdx-oss-task-check-alerts"
- name: APP_TYPE
Copy link
Collaborator Author

@wrn14897 wrn14897 Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used by internal logger

value: "scheduled-task"
resources:
{{- toYaml .Values.tasks.checkAlerts.resources | nindent 16 }}
{{- end }}
4 changes: 2 additions & 2 deletions charts/hdx-oss-v2/tests/configmap_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ tests:
path: data.USAGE_STATS_ENABLED
value: "true"
- equal:
path: data.CRON_IN_APP_DISABLED
path: data.RUN_SCHEDULED_TASKS_EXTERNALLY
value: "false"
- matchRegex:
path: data.MONGO_URI
Expand Down Expand Up @@ -85,4 +85,4 @@ tests:
asserts:
- equal:
path: data.FRONTEND_URL
value: "http://custom-host:4000"
value: "http://custom-host:4000"