feat: add livenessProbe and readinessProbe to all services #88
Conversation
🦋 Changeset detectedLatest commit: e778a9d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
knudtty
force-pushed
the
aaron/health-probes
branch
from
2a07fe1 to
840a450
Compare
|
@knudtty can you please add some helm unit tests to this? Thanks |
| command: | ||
| - mongosh | ||
| - --eval | ||
| - "db.adminCommand('ping')" |
There was a problem hiding this comment.
just curious where this came from? I hesitate to run elevated commands as part of a liveness or readiness probe.
Maybe we do just a simple tcpport listening check?
tcpSocket:
port: {{ .Values.mongodb.port }}
There was a problem hiding this comment.
From what I can tell online that's the healthcheck that is recommended for mongo, but there really isn't much info to find on this. I get the apprehension on admin privileges though, I'll adopt the tcpSocket approach
Closes HDX-1992
Adds livenessProbe and readinessProbe to mongo, clickhouse, otel-collector, and hyperdx services.
Tested on cluster and chart rendering via
helm template test ./charts/hdx-oss-v2 --set otel.enabled=true --set clickhouse.enabled=true --set mongodb.enabled=true