DateRangePicker: add ability to use predefined ranges #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hoorayimhelping
force-pushed
the
bucky-daterangepicker-predefined
branch
from
8dab553 to
4b19865
Compare
|
Hey @hoorayimhelping , sorry for the late reply. I was wondering, could we do this instead? I realize you may need to make more than a simple change, but it would look better I think 🙂 
|
hoorayimhelping
force-pushed
the
bucky-daterangepicker-predefined
branch
from
4b19865 to
485cf73
Compare
crisalbu
approved these changes
Jul 28, 2025
hoorayimhelping
force-pushed
the
bucky-daterangepicker-predefined
branch
from
485cf73 to
e729692
Compare
hoorayimhelping
force-pushed
the
bucky-daterangepicker-predefined
branch
from
e729692 to
93e7eae
Compare
ariser
previously requested changes
Aug 1, 2025
| ); | ||
| })} | ||
| </ScrollableContainer> | ||
| <StyledDropdownItem onClick={handleCustomTimePeriodClick}> |
There was a problem hiding this comment.
can we show the calendar on hover?
less clicks
plus in general, I feel like I expect nested items in a dropdown to appear on hover rather than on click
cc @crisalbu
| )} | ||
| </PredefinedCalendarContainer> | ||
| ) : ( | ||
| <CalendarRenderer calendarOptions={calendarOptions}> |
There was a problem hiding this comment.
nitpick: this can be a variable, perhaps in a useMemo(), to avoid repeating all the props in two places
ariser
reviewed
Aug 1, 2025
ariser
dismissed
their stale review
Going on PTO next week, so I'll dismiss my request to unblock you
hoorayimhelping
force-pushed
the
bucky-daterangepicker-predefined
branch
from
93e7eae to
be605b8
Compare
hoorayimhelping
force-pushed
the
bucky-daterangepicker-predefined
branch
from
2e7e761 to
8f9a533
Compare
serdec
approved these changes
Aug 12, 2025
hoorayimhelping
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds predefined ranges to
DateRangePicker.maxRangeLengthfutureStartDatesDisabled, to disable start dates in the futurepredefined dates list
limit of 15 for
dateRangeLimit