Skip to content

fix: 🐛 pull request slack notification syntax errors#866

Merged
punkbit merged 4 commits intomainfrom
fix/pull-request-slack-notification-syntax-errors
Mar 4, 2026
Merged

fix: 🐛 pull request slack notification syntax errors#866
punkbit merged 4 commits intomainfrom
fix/pull-request-slack-notification-syntax-errors

Conversation

@punkbit
Copy link
Collaborator

@punkbit punkbit commented Mar 3, 2026

Why?

To fix pull request Slack notification GitHub workflow syntax errors, due to the unpredictability of user title and description characters. By introducing character escapes and utilisation of JSON to prevent YAML formatting possible issues, etc.

How?

  • Create escape script
  • Remove exit 1 when description is empty

Preview?

The following is from a playground/runtime

Screenshot 2026-03-03 at 11 50 24

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2026

⚠️ No Changeset found

Latest commit: 4863084

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@workflow-authentication-public
Copy link
Contributor

📚 Storybook Preview Deployed

✅ Preview URL: https://click-5c8qwd876-clickhouse.vercel.app

Built from commit: 01b216eb32a7c2161d7841b0c4ba2a395492b1d2

@punkbit punkbit merged commit ea3663b into main Mar 4, 2026
9 checks passed
@punkbit punkbit deleted the fix/pull-request-slack-notification-syntax-errors branch March 4, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants