Conversation
🦋 Changeset detectedLatest commit: 755535d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gjones
approved these changes
Mar 4, 2026
Collaborator
gjones
left a comment
gjones
left a comment
There was a problem hiding this comment.
I believe this is what was discussed in the slack thread with @hoorayimhelping. I have no horse in this race, but am +1 for code consistency.
Contributor
📚 Storybook Preview Deployed✅ Preview URL: https://click-ac3vm1lln-clickhouse.vercel.app Built from commit: |
punkbit
deleted the
chore/remove-lint-rule-for-forcing-array-generic-annotation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Removes the ESLint/TSLint rule that enforced arrays to be typed using generic syntax (Array) instead of the shorthand array syntax (T[]).
The generic array annotation style (Array) adds verbosity without meaningful benefit. Removing this lint rule allows developers to use idiomatic TypeScript, such as the more concise T[] shorthand, which reduces friction and improves readability, e.g., TypeScript docs, LSP will show T[] and not Array.
How?
Preview?
N/A