fix: 🐛 restore changes lost in PR 841-845 merge conflict resolution

[punkbit]

Why?

Help correct bad merge conflict decisions/resolutions caused by squash-merging chained branches and loss of base context. Public API changes from PR #845 had leaked into PR #841, resulting in incorrect decisions when merging main back to the target branch.

💡 Relates to #879

How?

• PR fix: 🐛 resolve circular dependencies (first pass) #841 merged with content that should have been in PR chore: 🤖 public api as exports source-of-truth #845
• src/index.ts reorganization with explicit public API exports
• generate-exports script infrastructure
• Removal of src/components/index.ts barrel file
• When resolving conflicts, the modular component split from commits e1261e8 and 0a80393 was incorrectly reverted—keeping components in Common/ instead of individual directories

Preview?

N/A

[changeset-bot]

🦋 Changeset detected

Latest commit: e91a340

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clickhouse/click-ui	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Claude finished @punkbit's task in 1m 23s —— View job

---

PR Review

• Read conventions
• Analyze PR diff and changed files
• Review component structure changes
• Post final review

---

This PR cleanly restores the intended architecture: dissolving the Common/ catch-all directory and giving each utility component its own focused directory. The changes are well-scoped and surgical.

Verified:

• ✅ All @/components/Common imports are gone — zero remaining references
• ✅ EmptyButton, CrossButton, GridCenter each moved to their own directory with proper index.ts
• ✅ FormRoot, Error, FormElementContainer consolidated into FormContainer/ and re-exported from its index.ts
• ✅ The old EllipsisContainer from Common was not used externally (confirmed by search) — safe to delete
• ✅ BaseButton was already present in Button/BaseButton.tsx — the Common copy was a duplicate, correctly removed

💡 Suggestion (non-blocking)

• SplitButton/SplitButton.tsx:4 imports BaseButton via a direct file path @/components/Button/BaseButton, bypassing the module's index.ts. This is a pre-existing pattern (not introduced here), but it creates an implicit dependency on implementation details. A future improvement would be to export BaseButton from Button/index.ts so it's part of the module's public contract.

---

✅ Looks great — clean restoration of the right architecture. Nice work! 🙌

[github-actions]

Claude finished @punkbit's task in 1m 0s —— View job

---

PR Review

• Read conventions
• Analyze PR diff and changed files
• Review component structure changes
• Post final review

---

Clean restoration of the intended architecture — dissolving Common/ and giving each utility component its own focused directory. The changes are surgical and well-scoped.

Verified:

• ✅ All @/components/Common imports replaced with correct module paths
• ✅ EmptyButton, CrossButton, GridCenter each moved to individual directories with index.ts
• ✅ FormRoot, Error, FormElementContainer collocated in FormContainer/ and re-exported from its index.ts
• ✅ BaseButton duplicate in Common/ removed — SplitButton now imports from @/components/Button/BaseButton directly
• ✅ src/index.ts unchanged — no unintended public API expansion

💡 Suggestion (non-blocking)

• FormContainer/index.ts:3-5: FormRoot, Error, and FormElementContainer are now exported from the module's public barrel. These are internal styled primitives not exposed via src/index.ts, so there's no public API impact — but exporting Error in particular could cause confusion since it shadows the JS built-in. A future improvement: move them to a FormContainer/internal.ts file to make the private-use intent explicit.

• SplitButton/SplitButton.tsx:4: pre-existing pattern (not introduced here) — imports BaseButton via @/components/Button/BaseButton bypassing Button/index.ts. Consider exporting BaseButton from Button/index.ts to make it part of the module's contract.

---

✅ Looks great — clean, minimal, and correct. Nice work! 🙌

[github-actions]

Claude finished @punkbit's task in 1m 4s —— View job

---

PR Review

• Read conventions
• Analyze PR diff and changed files
• Review component structure changes
• Post final review

---

Clean restoration of the intended architecture — dissolving Common/ and giving each utility component its own focused directory. The changes are surgical and consistent throughout.

Verified:

• ✅ Zero remaining @/components/Common imports across the entire codebase
• ✅ EmptyButton, CrossButton, GridCenter each in their own directory with a proper index.ts
• ✅ FormRoot, Error, FormElementContainer collocated in FormContainer/ and re-exported from its index.ts
• ✅ BaseButton duplicate in Common/ removed — SplitButton correctly redirected to @/components/Button/BaseButton
• ✅ EllipsisContainer removal is safe — local variants in Collapsible/IconWrapper.tsx and EllipsisContent/EllipsisContent.tsx are independent inline definitions, not consumers of the deleted Common/EllipsisContainer
• ✅ src/index.ts public API is unchanged — no unintended exports added

💡 Suggestions (non-blocking, pre-existing)

• FormContainer/index.ts:4: export { Error } shadows the JS built-in Error constructor. No public API impact since it's not re-exported from src/index.ts, but it could cause confusion for consumers of the FormContainer module. A rename to FieldError or moving to a FormContainer/internal.ts file would make intent clearer.

• SplitButton/SplitButton.tsx:4: Imports BaseButton via @/components/Button/BaseButton directly, bypassing Button/index.ts. Consider exporting BaseButton from Button/index.ts to make it part of the module's public contract. (Pre-existing — not introduced here.)

---

✅ Looks great — clean, minimal, and correct. Nice work! 🙌

[workflow-authentication-public]

📚 Storybook Preview Deployed

✅ Preview URL: https://click-2c6dbn23r-clickhouse.vercel.app

Built from commit: 90cbe0eddb0085038dac6135d3fdb8f8b5f93b58