Skip to content

Commit 3852897

Browse files
committed
skip test for releases where it is not supported
1 parent ce6afa3 commit 3852897

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

.github/workflows/build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ jobs:
153153
matrix:
154154
# most recent LTS releases as well as latest stable builds
155155
# https://github.com/ClickHouse/ClickHouse/pulls?q=is%3Aopen+is%3Apr+label%3Arelease
156-
clickhouse: ["23.8", "24.3", "24.6", "latest"]
156+
clickhouse: ["23.8", "24.3", "24.8", "latest"]
157157
fail-fast: false
158158
timeout-minutes: 15
159159
name: Java client + CH ${{ matrix.clickhouse }}
@@ -335,7 +335,7 @@ jobs:
335335
needs: compile
336336
strategy:
337337
matrix:
338-
clickhouse: ["23.8", "24.3", "24.6", "latest"]
338+
clickhouse: ["23.8", "24.3", "24.8", "latest"]
339339
# grpc is not fully supported, and http_client and apache_http_client do not work in CI environment(due to limited threads?)
340340
protocol: ["http"]
341341
r2dbc: ["1.0.0.RELEASE", "0.9.1.RELEASE"]
@@ -452,7 +452,7 @@ jobs:
452452
matrix:
453453
# most recent LTS releases as well as latest stable builds
454454
# https://github.com/ClickHouse/ClickHouse/pulls?q=is%3Aopen+is%3Apr+label%3Arelease
455-
clickhouse: ["24.6", "latest"]
455+
clickhouse: ["24.3", "24.8", "latest"]
456456
fail-fast: false
457457
timeout-minutes: 15
458458
name: Client V2 + CH ${{ matrix.clickhouse }}

client-v2/src/test/java/com/clickhouse/client/query/QueryTests.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1796,7 +1796,11 @@ public void testReadingBitmap() throws Exception {
17961796

17971797
@Test(groups = {"integration"})
17981798
public void testReadingJSONValues() throws Exception {
1799-
1799+
List<GenericRecord> serverVersion = client.queryAll("SELECT version()");
1800+
if (ClickHouseVersion.of(serverVersion.get(0).getString(1)).check("(,24.8]")) {
1801+
System.out.println("Test is skipped: feature is supported since 24.8");
1802+
return;
1803+
}
18001804
CommandSettings commandSettings = new CommandSettings();
18011805
commandSettings.serverSetting("allow_experimental_json_type", "1");
18021806
client.execute("DROP TABLE IF EXISTS test_json_values", commandSettings).get(1, TimeUnit.SECONDS);

0 commit comments

Comments
 (0)