[repo] Fix tests reading query_log by closing query before flushing logs.
#2528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
mshustov
reviewed
Aug 10, 2025
| final String logQuery ="SELECT http_user_agent " + | ||
| " FROM system.query_log WHERE query = '" + testQuery.replaceAll("'", "\\\\'") + "'"; | ||
|
|
||
| final String logQuery ="SELECT http_user_agent FROM system.query_log WHERE query_id = " + stmt.enquoteLiteral(queryId); |
There was a problem hiding this comment.
I don't see clusterAllReplicas added as the PR title says
There was a problem hiding this comment.
Fair point. Will fix the title
There was a problem hiding this comment.
Fixed. Title and description.
There was a problem hiding this comment.
Added clusterAllreplicas to tests.
chernser
changed the title
query_log with clusterAllReplicasquery_log by closing query before flushing logs.
|
mshustov
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are test that look for some query in the query log. However this tests did not close response object of the query they are looking for therefor query log missing a record.
This PR fixes the issue.
Checklist
Delete items not relevant to your PR: