[JDBC] ResultImpl fixed #2530
Open
[JDBC] ResultImpl fixed #2530
+473
−220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed methods in result setimpl
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
chernser
requested review from
mzitnik and
Copilot
and removed request for
mzitnik
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the JDBC ResultSet implementation by introducing a FeatureManager to consistently handle unsupported operations and adds comprehensive test coverage. The changes improve the handling of JDBC operations that are not supported by ClickHouse while providing better control over whether exceptions are thrown.
- Introduces
FeatureManagerclass to centralize handling of unsupported JDBC operations - Adds extensive test coverage for unsupported ResultSet methods and cursor positioning
- Implements proper fetch size handling and row position tracking in ResultSet
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
StatementTest.java |
Updates test expectation for getFetchSize() to return the set value instead of 0 |
ResultSetImplTest.java |
Adds comprehensive tests for unsupported operations, cursor positioning, fetch operations, and metadata handling |
FeatureManager.java |
New utility class to centralize handling of unsupported JDBC features based on configuration |
StatementImpl.java |
Implements proper fetch size handling and fixes statement closure logic |
ResultSetImpl.java |
Refactors to use FeatureManager and implements row position tracking and fetch size management |
jdbc-v2/src/test/java/com/clickhouse/jdbc/ResultSetImplTest.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2415
Checklist
Delete items not relevant to your PR: