Skip subcolumns of ephemeral, alias, and materialized columns#660
Open
kurnoolsaketh wants to merge 3 commits intomainfrom
Open
Skip subcolumns of ephemeral, alias, and materialized columns#660kurnoolsaketh wants to merge 3 commits intomainfrom
kurnoolsaketh wants to merge 3 commits intomainfrom
Conversation
kurnoolsaketh
force-pushed
the
bugfix/skip-subcolumns
branch
from
7a792eb to
5993ced
Compare
Author
|
btw all: for some reason the test I added is passing for me locally but failing in CI - I will fix it when i'm back from PTO |
mzitnik
reviewed
Feb 19, 2026
Collaborator
mzitnik
left a comment
mzitnik
left a comment
There was a problem hiding this comment.
Can we also add a test that actually writes to ClickHouse, it will also test other aspects of writing & validation.
Collaborator
|
@kurnoolsaketh, but lets check why tests are failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes: #644
Previously, subcolumns of ephemeral, alias, and materialized were included in the table description but their parent columns were filtered out. This PR filters out the subcolumns. As a result, the warn log below will no longer be emitted when a subcolumn of an ephemeral/alias/materialized is encountered:
Also, format the changed the files.
Checklist
Delete items not relevant to your PR: