feat: HTTP TableBatcher with auto-flush triggers#406
Open
catinspace-au wants to merge 1 commit intoClickHouse:mainfrom
Open
feat: HTTP TableBatcher with auto-flush triggers#406catinspace-au wants to merge 1 commit intoClickHouse:mainfrom
catinspace-au wants to merge 1 commit intoClickHouse:mainfrom
Conversation
New TableBatcher<T> wraps Inserter<T> with a shared buffer and background flush task. Callers use append/flush/send without managing timers manually. Flushes on max_bytes, max_rows, or period thresholds (whichever fires first). API mirrors the ClickHouse Go client's Batch interface. Requires the `batcher` feature flag (implies `inserter`).
catinspace-au
requested review from
abonander,
joe-clickhouse,
kavirajk and
peter-leonov-ch
as code owners
catinspace-au
force-pushed
the
hyperi/batching
branch
from
92040a7 to
f97f650
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Independent of other PRs -- can merge in any order.
TableBatcher with three flush triggers: max rows, max bytes, max
period. Background tokio task for timer flush. Thread-safe via
Arctokio::sync::Mutex.
API mirrors the Go client Batch interface -- append(), flush(), send().