Integration tests Cluster #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # flink-connector-clickhouse-1.17/build.gradle.kts # flink-connector-clickhouse-2.0.0/build.gradle.kts # flink-connector-clickhouse-base/build.gradle.kts
flink-connector-clickhouse-base/src/testFixtures/java/com/clickhouse/flink/Cluster.java
Outdated
Show resolved
Hide resolved
flink-connector-clickhouse-base/src/testFixtures/java/com/clickhouse/flink/Cluster.java
Outdated
Show resolved
Hide resolved
flink-connector-clickhouse-base/src/testFixtures/java/com/clickhouse/flink/Cluster.java
Show resolved
Hide resolved
flink-connector-clickhouse-base/src/testFixtures/java/com/clickhouse/flink/Cluster.java
Outdated
Show resolved
Hide resolved
flink-connector-clickhouse-base/src/testFixtures/java/com/clickhouse/flink/Cluster.java
Show resolved
Hide resolved
...base/src/testFixtures/java/org/apache/flink/connector/test/FlinkClusterIntegrationTests.java
Outdated
Show resolved
Hide resolved
...base/src/testFixtures/java/org/apache/flink/connector/test/FlinkClusterIntegrationTests.java
Outdated
Show resolved
Hide resolved
...base/src/testFixtures/java/org/apache/flink/connector/test/FlinkClusterIntegrationTests.java
Outdated
Show resolved
Hide resolved
...tures/java/org/apache/flink/connector/test/embedded/clickhouse/ClickHouseServerForTests.java
Show resolved
Hide resolved
|
|
||
| public static Network getNetwork() { | ||
| if (isCloud()) | ||
| return Network.newNetwork(); |
There was a problem hiding this comment.
Here, we always create a new network for the cloud, but in public static void setUp(boolean bridge) throws InterruptedException, ExecutionException we don't. Can't we create it once there and reuse it?
Contributor
Author
There was a problem hiding this comment.
I will try to explain.
When running against the cloud, we do not care about the network we are operating from, but when running against a container, we need to be in the same network for Flink and ClickHouse.
There was a problem hiding this comment.
I understand that my question was around whether we can create it once and reuse it? (in the setUp function)
Contributor
Author
There was a problem hiding this comment.
In some cases, you need to use the network that was created by the ClickHouse container, and in the cloud, it does not matter.
...nector-clickhouse-integration/src/test/java/com/clickhouse/flink/integration/FlinkTests.java
Show resolved
Hide resolved
...nector-clickhouse-integration/src/test/java/com/clickhouse/flink/integration/FlinkTests.java
Outdated
Show resolved
Hide resolved
...nector-clickhouse-integration/src/test/java/com/clickhouse/flink/integration/FlinkTests.java
Outdated
Show resolved
Hide resolved
...nector-clickhouse-integration/src/test/java/com/clickhouse/flink/integration/FlinkTests.java
Show resolved
Hide resolved
...nector-clickhouse-integration/src/test/java/com/clickhouse/flink/integration/FlinkTests.java
Show resolved
Hide resolved
BentsiLeviav
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cluster integration tests
Closes #34
Checklist
Delete items not relevant to your PR: