Skip to content

Conversation

@barryrobison
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2025

CLA assistant check
All committers have signed the CLA.

andreev-io
andreev-io previously approved these changes Feb 11, 2025
@andreev-io andreev-io linked an issue Feb 11, 2025 that may be closed by this pull request
@andreev-io
Copy link
Member

It seems that load: true forces a single-arch build to happen.

@barryrobison barryrobison force-pushed the feat/multi-arch-image branch 2 times, most recently from 7219c82 to f67f13b Compare February 11, 2025 10:32
@barryrobison
Copy link
Contributor Author

It seems that load: true forces a single-arch build to happen.

Yeah sorry about that - I've pushed some changes which result in a successful image build:

https://github.com/barryrobison/kubenetmon/actions/runs/13260886777/job/37017019057

but the tests are failing. I'll have another look tomorrow to troubleshoot if that's due to the image.

Thanks!
-baz

@andreev-io
Copy link
Member

Thank you for making the contribution! I'll take a deeper look at what's the right approach tomorrow as well.

@andreev-io andreev-io force-pushed the feat/multi-arch-image branch from f67f13b to 8dad387 Compare February 17, 2025 18:31
@andreev-io
Copy link
Member

@barryrobison Test issues were related to a recent update to the ClickHouse image where default user password became required. I updated that on main and your change is now passing CI. I'm going to merge it, thank you for the contribution!

@andreev-io andreev-io merged commit 0a6abb9 into ClickHouse:main Feb 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multi-arch images?

3 participants