Skip to content

Add support for time_bounds to identify time slices in NcFileVector #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paullric merged 1 commit into from
Jan 13, 2026
Merged

Add support for time_bounds to identify time slices in NcFileVector #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/base/NcFileVector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ void NcFileVector::clear() {
m_vecNcFile.resize(0);
m_vecFilenames.resize(0);
m_vecFileType.resize(0);
m_vecFileTime.resize(0);
m_time = Time(Time::CalendarUnknown);
m_vecTimeIxs.resize(0);
}
Expand Down Expand Up @@ -223,12 +224,26 @@ long NcFileVector::GetTimeIx(size_t pos) const {
_ASSERT(vecTimes.size() > 0);

if (m_vecFileType[pos] == NcFileVector::FileType_Standard) {

// Try to identify exact timestamp
for (long t = 0; t < vecTimes.size(); t++) {
if (vecTimes[t] == m_time) {
return t;
}
}

// Use time bounds
if (vecTimes.m_vecTimeBounds.size() != 0) {
_ASSERT(vecTimes.m_vecTimeBounds.size() == vecTimes.size());
for (long t = 0; t < vecTimes.size(); t++) {
if ((vecTimes.m_vecTimeBounds[t].first <= m_time) &&
(vecTimes.m_vecTimeBounds[t].second > m_time)
) {
return t;
}
}
}

} else if (m_vecFileType[pos] == NcFileVector::FileType_DailyMeanClimo) {
Time timeDailyMean(Time::CalendarNoLeap);
timeDailyMean.SetYear(1);
Expand Down
116 changes: 104 additions & 12 deletions src/base/NetCDFUtilities.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,12 +968,12 @@ void ReadCFTimeDataFromNcFile(
NcVar * varTime = NcGetTimeVariable(*ncfile);

if (varTime == NULL) {
_EXCEPTION1("Variable \"time\" not found in file \"%s\"",
_EXCEPTION1("Variable \"time\" or equivalent not found in file \"%s\"",
strFilename.c_str());
}
if (dimTime == NULL) {
if (varTime->num_dims() != 0) {
_EXCEPTION1("Dimension \"time\" not found in file \"%s\"",
_EXCEPTION1("Dimension \"time\" or equivalent not found in file \"%s\"",
strFilename.c_str());
}
lTimeCount = 1;
Expand Down Expand Up @@ -1033,35 +1033,35 @@ void ReadCFTimeDataFromNcFile(
vecTimes.m_units = attTimeUnits->as_string(0);

// Load in time data
DataArray1D<int> vecTimeInt;
DataArray1D<float> vecTimeFloat;
DataArray1D<double> vecTimeDouble;
DataArray1D<ncint64> vecTimeInt64;
std::vector<int> vecTimeInt;
std::vector<float> vecTimeFloat;
std::vector<double> vecTimeDouble;
std::vector<ncint64> vecTimeInt64;

if (varTime->type() == ncInt) {
vecTimeInt.Allocate(lTimeCount);
vecTimeInt.resize(lTimeCount);
varTime->set_cur((long)0);
varTime->get(&(vecTimeInt[0]), lTimeCount);

} else if (varTime->type() == ncFloat) {
vecTimeFloat.Allocate(lTimeCount);
vecTimeFloat.resize(lTimeCount);
varTime->set_cur((long)0);
varTime->get(&(vecTimeFloat[0]), lTimeCount);

} else if (varTime->type() == ncDouble) {
vecTimeDouble.Allocate(lTimeCount);
vecTimeDouble.resize(lTimeCount);
varTime->set_cur((long)0);
varTime->get(&(vecTimeDouble[0]), lTimeCount);

} else if (varTime->type() == ncInt64) {
vecTimeInt64.Allocate(lTimeCount);
vecTimeInt64.resize(lTimeCount);
varTime->set_cur((long)0);
varTime->get(&(vecTimeInt64[0]), lTimeCount);

} else {
_EXCEPTION1("Variable \"time\" has invalid type "
_EXCEPTION2("Variable \"%s\" has invalid type "
"(expected \"int\", \"int64\", \"float\" or \"double\")"
" in file \"%s\"", strFilename.c_str());
" in file \"%s\"", varTime->name(), strFilename.c_str());
}

for (int t = 0; t < lTimeCount; t++) {
Expand Down Expand Up @@ -1094,6 +1094,98 @@ void ReadCFTimeDataFromNcFile(

vecTimes.push_back(time);
}

// Load in time bounds
NcVar * varTimeBounds = NULL;

NcAtt * attBounds = varTime->get_att("bounds");
if (attBounds != NULL) {
varTimeBounds = ncfile->get_var(attBounds->as_string(0));
}
if (varTimeBounds == NULL) {
varTimeBounds = ncfile->get_var("time_bnds");
}
if (varTimeBounds == NULL) {
varTimeBounds = ncfile->get_var("time_bounds");
}
if (varTimeBounds != NULL) {
if (varTimeBounds->num_dims() != 2) {
_EXCEPTION1("Time bounds variable \"%s\" must have two dimensions", varTimeBounds->name());
}
if (varTimeBounds->get_dim(0)->size() != lTimeCount) {
_EXCEPTION2("Time bounds variable \"%s\" first dimension must have same length as time variable \"%s\"",
varTimeBounds->name(), varTime->name());
}
if (varTimeBounds->get_dim(1)->size() != 2) {
_EXCEPTION1("Time bounds variable \"%s\" second dimension must be size 2",
varTimeBounds->name());
}

if (varTimeBounds->type() == ncInt) {
vecTimeInt.resize(2 * lTimeCount);
varTimeBounds->set_cur(0, 0);
varTimeBounds->get(&(vecTimeInt[0]), lTimeCount, 2);

} else if (varTime->type() == ncFloat) {
vecTimeFloat.resize(2 * lTimeCount);
varTimeBounds->set_cur(0, 0);
varTimeBounds->get(&(vecTimeFloat[0]), lTimeCount, 2);

} else if (varTime->type() == ncDouble) {
vecTimeDouble.resize(2 * lTimeCount);
varTimeBounds->set_cur(0, 0);
varTimeBounds->get(&(vecTimeDouble[0]), lTimeCount, 2);

} else if (varTime->type() == ncInt64) {
vecTimeInt64.resize(2 * lTimeCount);
varTimeBounds->set_cur(0, 0);
varTimeBounds->get(&(vecTimeInt64[0]), lTimeCount, 2);

} else {
_EXCEPTION2("Variable \"%s\" has invalid type "
"(expected \"int\", \"int64\", \"float\" or \"double\")"
" in file \"%s\"", varTimeBounds->name(), strFilename.c_str());
}

for (int t = 0; t < lTimeCount; t++) {
std::pair<Time,Time> prTimeBound;
for (int tb = 0; tb < 2; tb++) {
Time time(eCalendarType);

if (varTimeBounds->type() == ncInt) {
time.FromCFCompliantUnitsOffsetInt(
vecTimes.m_units,
vecTimeInt[2*t+tb]);

} else if (varTimeBounds->type() == ncFloat) {
time.FromCFCompliantUnitsOffsetDouble(
vecTimes.m_units,
static_cast<double>(vecTimeFloat[2*t+tb]));

} else if (varTimeBounds->type() == ncDouble) {
time.FromCFCompliantUnitsOffsetDouble(
vecTimes.m_units,
vecTimeDouble[2*t+tb]);

} else if (varTimeBounds->type() == ncInt64) {
time.FromCFCompliantUnitsOffsetInt(
vecTimes.m_units,
(int)(vecTimeInt64[2*t+tb]));
}

#if defined(ROUND_TIMES_TO_NEAREST_MINUTE)
time.RoundToNearestMinute();
#endif
if (tb == 0) {
prTimeBound.first = time;
} else {
prTimeBound.second = time;
}
}

vecTimes.m_vecTimeBounds.push_back(prTimeBound);
}
}
}

////////////////////////////////////////////////////////////////////////////////
Expand Down
5 changes: 5 additions & 0 deletions src/base/NetCDFUtilities.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,11 @@ class NcTimeDimension : public std::vector<Time> {
/// Associated type of time.
/// </summary>
TimeDimType m_dimtype;

/// <summary>
/// Time bounds.
/// </summary>
std::vector< std::pair<Time,Time> > m_vecTimeBounds;
};

////////////////////////////////////////////////////////////////////////////////
Expand Down