Update Face::Contains Function
#90
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongyuchen1030
commented
Jan 29, 2025
| ) const { | ||
| int nParity = 0; | ||
|
|
||
| // First check if the query point N0 is around pole area. The following check base on the assumption that a face will not contains both ppole points |
Collaborator
Author
There was a problem hiding this comment.
Consider using line of longnitude, for pole point case, use constant lat
Collaborator
Author
There was a problem hiding this comment.
Divide the sphere into regions and use the mono-tone characteristic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
bool Face::Contains(const Node &n0, const NodeVector &nodevec) constfunction to account for marginal cases, fix potential bugs, and improve its robustness.