Draft
Conversation
This field was missing from the INFO header which broke the scoring step (error related to plugin not defined in VCF header). The introduced header definition is copied from test_vcf_annotated.vcf file. Signed-off-by: Tor Björgen <tor.bjorgen@scilifelab.se>
…s to VCF fixture Signed-off-by: Tor Björgen <tor.bjorgen@scilifelab.se>
This is a better option than the default logging module since it provides process level insight as well as prints logging output to stdout/err.
Errors in run method is not visible on stdout/err by default. Log error and stacktrace. Signed-off-by: Tor Björgen <tor.bjorgen@scilifelab.se>
When subprocess compound scorers fails and stops decreasing semaphore counter, while main process is in queue join() waiting for completion, we have a deadlock. Avoid this situation by checking subprocess states before joining on queue so that processing can be aborted properly and errors made visible. Signed-off-by: Tor Björgen <tor.bjorgen@scilifelab.se>
torbjorgen
force-pushed
the
rescoring_with_additional_suffix
branch
3 times, most recently
from
01683b0 to
3a74cba
Compare
This patch adds functionality to rescore a VCF (potentially with a different score config) and append the scoring results to the VCF where the score annotations are suffixed. Signed-off-by: Tor Björgen <tor.bjorgen@scilifelab.se>
Signed-off-by: Tor Björgen <tor.bjorgen@scilifelab.se>
Signed-off-by: Tor Björgen <tor.bjorgen@scilifelab.se>
torbjorgen
force-pushed
the
rescoring_with_additional_suffix
branch
from
3a74cba to
bd7bdbd
Compare
Contributor
Author
|
This is the genmod _suffix branch we talked about in the RDDS meeting today: @jemten @peterpru @ramprasadn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains patches to allow genmod to "rescore" and add rank scores with
[SUFFIX]to a prescored VCF.See added test for usage.
Executing tests:
docker run -i -l genmod-test genmod/test -v -s -o log_cli=true -k test_rescore_with_annotation_suffix 2>&1