Skip to content

Return phased genotype string from Genotype class if variant is phased#195

Open
fellen31 wants to merge 6 commits intomainfrom
print-phased-calls-from-genotype
Open

Return phased genotype string from Genotype class if variant is phased#195
fellen31 wants to merge 6 commits intomainfrom
print-phased-calls-from-genotype

Conversation

@fellen31
Copy link
Contributor

@fellen31 fellen31 commented Mar 9, 2026

Description

While debugging other parts of the code, I found it useful if the Genotype class could return unphased and phased genotypes, rather than always representing the genotypes with / as delimiter.

I changed the Genotype class to make it slightly more understandable (in my opinion). Let me know if you don't agree and we can change it back.

Changed

  • Return phased genotype string from Genotype class if variant is phased
  • Slightly more readable Genotype class

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_[TOOL]-t [TOOL] -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@fellen31 fellen31 linked an issue Mar 9, 2026 that may be closed by this pull request
@fellen31 fellen31 marked this pull request as ready for review March 9, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Genotype class not printing phased calls

1 participant