Skip to content

Use PS-tag to check compounds#197

Open
fellen31 wants to merge 9 commits intomainfrom
use-ps-tag
Open

Use PS-tag to check compounds#197
fellen31 wants to merge 9 commits intomainfrom
use-ps-tag

Conversation

@fellen31
Copy link
Contributor

@fellen31 fellen31 commented Mar 9, 2026

Description

Closes #192. Closes #196.

Changed

  • Changed to use PS-tag instead of intervals to check for variants in phase with genmod models --phased, since this is simpler and more reliable
  • Refactored the implementation of check_compounds() to improve maintainability

Fixed

  • KeyError when running genmod models --phased with multiple individuals (#197)

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_[TOOL]-t [TOOL] -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@fellen31 fellen31 marked this pull request as ready for review March 9, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider reusing haploblocks from existing phasing files genmod models gives a KeyError with --phasedparameter if multiple samples

1 participant