Skip to content

adding modality for queries towards pasteur database#206

Merged
karlnyr merged 32 commits intorc4.2.0from
add-pubmlst-pasteur-auth
May 6, 2025
Merged

adding modality for queries towards pasteur database#206
karlnyr merged 32 commits intorc4.2.0from
add-pubmlst-pasteur-auth

Conversation

@karlnyr
Copy link
Contributor

@karlnyr karlnyr commented Apr 11, 2025

Description

##Remove elements in cursive as needed.##

The features of this PR primarily concerns end-users/bioinformaticians/internals

Summary of the changes made:

If not self-evident, mention what prompted the change.

Primary function of PR

  • Hotfix
  • Patch
  • Minor functionality improvement
  • New type of analysis
  • Backward-breaking functionality improvement
  • This change requires internal documents to be updated
  • This change requires another repository to be updated

Testing

If the update is a hotfix, it is sufficient to rely on the development testing along with the Travis self-test automatically applied to the PR.

Test routine to verify the stability of the PR:

  • bash /home/proj/production/servers/resources/hasta.scilifelab.se/install-microsalt-stage.sh BRANCHNAME
  • us
  • conda activate S_microSALT
  • (SITUATIONAL) export MICROSALT_CONFIG=/home/proj/dropbox/microSALT.json
  • Select a relevant subset of the following:
  • microSALT analyse project MIC3109
  • microSALT analyse project MIC4107
  • microSALT analyse project MIC4109
  • microSALT analyse project ACC5551

Verify that the results for projects MIC3109, MIC4107, MIC4109 & ACC5551 are consistent with the results attached to AMSystem doc 1490, Microbial_WGS.xlsx

Test results

These are the results of the tests, and necessary conclusions, that prove the stability of the PR.

Sign-offs

@karlnyr karlnyr requested a review from a team as a code owner April 11, 2025 08:15
@karlnyr
Copy link
Contributor Author

karlnyr commented Apr 29, 2025

Testing new authentication to pasteur:

[15:21] [hiseq.clinical@hasta:/home/proj/stage/bin/git/microSALT] [S_microSALT]  (add-pubmlst-pasteur-auth) $ python microSALT/utils/pubmlst/get_credentials.py -s pasteur -sp klebsiella
Please log in using your user account at https://bigsdb.pasteur.fr/cgi-bin/bigsdb/bigsdb.pl?db=pubmlst_klebsiella_seqdef&page=authorizeClient&oauth_token=token using a web browser to obtain a verification code.
Please enter verification code: verification_code

Access Token: access_token
Access Token Secret: token_secret
Tokens saved to /home/proj/stage/microbial/credentials/pasteur_credentials.env

@karlnyr karlnyr force-pushed the add-pubmlst-pasteur-auth branch from 6c6eebe to 634a344 Compare April 29, 2025 13:45
@karlnyr
Copy link
Contributor Author

karlnyr commented Apr 30, 2025

Testing with the fixed variables:

image

Copy link
Contributor

@samuell samuell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got some various minor nitpicks, but otherwise looks good to me.

@karlnyr karlnyr merged commit ac2bdb1 into rc4.2.0 May 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants