Skip to content

Commit 658caf6

Browse files
fix: Remove unused parameter custom_extra_files (#51)
### Fixed - Updated parameters documentation. ### Removed - Unused parameter `custom_extra_files`.
1 parent 70ff348 commit 658caf6

File tree

5 files changed

+4
-10
lines changed

5 files changed

+4
-10
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,3 +53,4 @@ Initial release of Clinical-Genomics/oncorefiner, created with the [nf-core](htt
5353
### `Removed`
5454

5555
- Removed CI checks `awstest` and `awsfulltest` [#18](https://github.com/Clinical-Genomics/oncorefiner/pull/18)
56+
- Removed unused parameter `custom_extra_files` [#51](https://github.com/Clinical-Genomics/oncorefiner/pull/51)

docs/parameters.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ Reference genome related files and options required for the workflow.
1919

2020
| Parameter | Description | Type | Default | Required | Hidden |
2121
|-----------|-----------|-----------|-----------|-----------|-----------|
22+
| `genome` | Name of the genome reference. (accepted: `GRCh38`\|`GRCh37`) <details><summary>Help</summary><small>Use this parameter to specify the ID for the reference genome used. This is then used to annotate the SV and SNV files e.g. `--genome GRCh38`.</small></details>| `string` | GRCh38 | | |
2223
| `fasta` | Path to FASTA genome file. <details><summary>Help</summary><small>If you don't have a BWA index available this will be generated for you automatically. Combine with `--save_reference` to save BWA index for future runs.</small></details>| `string` | | | |
2324
| `fai` | Path to FASTA genome index file. <details><summary>Help</summary><small>If none provided, will be generated automatically from the FASTA reference</small></details>| `string` | | | |
24-
| `genome` | Name of the genome reference. (accepted: `GRCh38`\|`GRCh37`) <details><summary>Help</summary><small>Use this parameter to specify the ID for the reference genome used. This is then used to annotate the SV and SNV files e.g. `--genome GRCh38`.</small></details>| `string` | GRCh38 | | |
2525
| `species` | Species of the reference genome. E.g. `--species homo_sapiens`. (accepted: `homo_sapiens`) | `string` | homo_sapiens | | |
2626

2727
## Annotation options
@@ -81,4 +81,3 @@ Less common options for the pipeline, typically set in a config file.
8181
|-----------|-----------|-----------|-----------|-----------|-----------|
8282
| `snv_vcf` | | `string` | | | |
8383
| `sv_vcf` | | `string` | | | |
84-
| `custom_extra_files` | | `string` | | | |

nextflow.config

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ params {
2222
vep_cache_version = 112
2323
vep_plugin_files = null
2424
vep_cache = null
25-
custom_extra_files = null
2625

2726
// Vcfanno
2827
vcfanno_toml = null

nextflow_schema.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -339,9 +339,6 @@
339339
},
340340
"sv_vcf": {
341341
"type": "string"
342-
},
343-
"custom_extra_files": {
344-
"type": "string"
345342
}
346343
}
347344
}

workflows/oncorefiner.nf

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,7 @@ workflow ONCOREFINER {
138138
// VEP
139139
RESEARCH_FILTERING.out.vcf
140140
.map { meta, vcf ->
141-
def custom_extra_files = params.custom_extra_files ? file(params.custom_extra_files) : []
142-
tuple(meta, vcf, custom_extra_files)
141+
tuple(meta, vcf, [])
143142
}
144143
.set { ch_vep_snv }
145144

@@ -202,8 +201,7 @@ workflow ONCOREFINER {
202201
// VEP
203202
RESEARCH_FILTERING_SV.out.vcf
204203
.map { meta, vcf ->
205-
def custom_extra_files = params.custom_extra_files ? file(params.custom_extra_files) : []
206-
tuple(meta, vcf, custom_extra_files) }
204+
tuple(meta, vcf, []) }
207205
.set { ch_vep_sv }
208206

209207

0 commit comments

Comments
 (0)