Skip to content

Conversation

@seuros
Copy link
Member

@seuros seuros commented Jan 15, 2026

The build started to fail because SqliteRecord is reserved in the new version of sqlite3.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames testing classes from database-specific names (MysqlRecord, SqliteRecord) to more generic names (SecondaryRecord, LiteRecord) to avoid conflicts with reserved names in newer versions of Ruby/Rails. The changes are consistent across model files, schema files, test files, and configuration.

Changes:

  • Renamed MysqlRecordSecondaryRecord and SqliteRecordLiteRecord across all model classes and test files
  • Updated database table names from mysql_*secondary_* and sqlite_*lite_* in schema files
  • Updated database configuration key from :sqlite:lite
  • Updated Ruby version from 3.4.7 to 3.4.8

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/test_helper.rb Updated DatabaseCleaner configuration to use new record class names
test/dummy/db/sqlite_schema.rb Renamed sqlite table definitions to lite
test/dummy/db/secondary_schema.rb Renamed mysql table definitions to secondary
test/dummy/db/schema.rb Updated multi-database test table names to use new naming convention
test/dummy/db/mysql_schema.rb Removed deprecated mysql schema file
test/dummy/config/database.yml Renamed database configuration key from sqlite to lite
test/dummy/app/models/sqlite_record.rb Removed old SqliteRecord class definition
test/dummy/app/models/secondary_tag.rb Updated class to inherit from SecondaryRecord
test/dummy/app/models/secondary_record.rb Renamed class from MysqlRecord to SecondaryRecord
test/dummy/app/models/secondary_adoptable_tag.rb Updated class to inherit from SecondaryRecord
test/dummy/app/models/memory_tag.rb Updated class to inherit from LiteRecord
test/dummy/app/models/memory_adoptable_tag.rb Updated class to inherit from LiteRecord
test/dummy/app/models/lite_record.rb Added new LiteRecord class replacing SqliteRecord
test/closure_tree/parallel_test.rb Updated to use LiteRecord connection methods
test/closure_tree/multi_database_test.rb Updated all references from SqliteRecord/MysqlRecord to LiteRecord/SecondaryRecord
test/closure_tree/adopt_test.rb Updated adopt test invocations to use new class names
lib/closure_tree/support.rb Updated comment to reference SecondaryRecord instead of MysqlRecord
.tool-versions Updated Ruby version from 3.4.7 to 3.4.8

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@seuros seuros merged commit 31fbb28 into master Jan 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants