Feedback #1
Feedback #1
Conversation
|
I tried to implement Queueable Apex for this work and to bulkify upsert(update) but it didn't work, because the HttpCalloutMock returns only one result and the |
|
I didn't stop thinking about bulkification and finally implemented an alternative variant and added it to another pull request. |
walters954
left a comment
walters954
left a comment
There was a problem hiding this comment.
Very good job. Your code is excellent.
I'll challenge you to write an additional test cases implementing additional mock calls.
| */ | ||
| public override void afterUpdate() { | ||
| for (Contact cont : newConts) { | ||
| if (Integer.valueOf(cont.DummyJSON_Id__c) > 100 && !System.isFuture()) { |
There was a problem hiding this comment.
Also consider adding an additional validation on the DummyJSON_Last_Updated__c field.
| List<String> dummyJSONIdList = new List<String>(); | ||
| for (Contact cont : newConts) { | ||
| if (cont.DummyJSON_Id__c == null) { | ||
| cont.DummyJSON_Id__c = String.valueOf(Math.round(Math.random() * 100)); |
| HttpRequest request = new HttpRequest(); | ||
| // Set the endpoint URL. Use direct URL or for best practices use Named Credential. | ||
|
|
||
| request.setEndpoint('callout:DummyJsonUser' + '/' + dummyUserId); |
| valuesMap.put('firstName', String.isNotBlank(cont.FirstName) ? cont.FirstName : 'unknown'); | ||
| valuesMap.put('lastName', String.isNotBlank(cont.LastName) ? cont.LastName : 'unknown'); | ||
| valuesMap.put('email', String.isNotBlank(cont.Email) ? cont.Email : 'unknown'); | ||
| valuesMap.put('phone', String.isNotBlank(cont.Phone) ? cont.Phone : 'unknown'); |
There was a problem hiding this comment.
Nice work catching these values if they are empty.
Putting unknown for the email may cause an error.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mainsince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @ManoolK