Skip to content

Conversation

julianocosta89
Copy link
Member

@julianocosta89 julianocosta89 commented Mar 28, 2025

Re-opening this PR to investigate why this is not working when publishing.

Fix: #73

@julianocosta89
Copy link
Member Author

@jetzlstorfer I've reverted and re-opened your PR: #77 (comment)

Maybe we need to configure jekyll to bundle the new dependencies somehow.

@jetzlstorfer
Copy link
Member

oh no 😭

did it fire any error messages?

@jetzlstorfer
Copy link
Member

@jetzlstorfer jetzlstorfer self-assigned this Mar 28, 2025
@jetzlstorfer
Copy link
Member

jetzlstorfer commented Mar 28, 2025

good news @julianocosta89
I tested it and it now works.

With the Gemfile we now need a dedicated github actions workflow for the build and deployment. I've added it and temporarily pushed this branch to production. all worked fine. the github action is already on the main branch (sorry for bypassing the rules but I needed some way to test).
https://github.com/CloudNativeLinz/cloudnativelinz.github.io/blob/main/.github/workflows/jekyll-deploy.yml

Also I followed these instructions to make it work: https://docs.github.com/en/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#publishing-with-a-custom-github-actions-workflow

@jetzlstorfer
Copy link
Member

@julianocosta89
Copy link
Member Author

Awesome!!!
Thanks for taking care of this 🥰

@julianocosta89 julianocosta89 merged commit a644979 into main Mar 28, 2025
3 of 4 checks passed
@julianocosta89 julianocosta89 deleted the feature/73/merge-events-and-slides branch March 28, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge events.yaml with the _slides folder
2 participants