Skip to content

Conversation

@derklaro
Copy link
Member

@derklaro derklaro commented Dec 8, 2025

Motivation

Advanced patterns for message formats are not processed correctly when combined with our custom argument naming.

Modification

Improve the regex to allow for all message format patterns in combination with our custom naming format.

Result

Advanced message format patterns are correctly displayed when used in our translation system.

@derklaro derklaro added this to the 4.0.0-RC16 milestone Dec 8, 2025
@derklaro derklaro requested a review from 0utplay December 8, 2025 19:21
@derklaro derklaro self-assigned this Dec 8, 2025
@derklaro derklaro added v: 4.X This pull should be included in the 4.0 release in: driver An issue/pull request releated to the driver module code t: fix A pull request introducing a fix for a bug. labels Dec 8, 2025
@derklaro derklaro changed the title fix: advanced format pattern in translation provider fix: advanced format patterns in translation provider Dec 8, 2025
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Test Results

 56 files  ±0   56 suites  ±0   3m 56s ⏱️ + 1m 43s
571 tests +1  571 ✅ +1  0 💤 ±0  0 ❌ ±0 
938 runs  +1  938 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 8191cc6. ± Comparison against base commit a6824a4.

@0utplay 0utplay merged commit 891e69c into nightly Dec 8, 2025
7 checks passed
@0utplay 0utplay deleted the translation-format-patterns branch December 8, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: driver An issue/pull request releated to the driver module code t: fix A pull request introducing a fix for a bug. v: 4.X This pull should be included in the 4.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants