Open
Conversation
This reverts commit 9539184.
Contributor
Author
|
ubuntu CI error is with installing deps. It seems to be transient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit df131f9a to river-classic, broke the
--width-factor -Wfeature in bemenu, causing bemenu to always render with full width. From my testing with similar menu applications and sway, it seems to be strictly a bemenu/river-classic incompatibility. Based on issue #449, I'm inclined to believe that river simply exposed an existing bug in bemenu.My PR should be considered a hotfix. It doesn't actually fix #449 because I'm frankly ignorant what a correct wayland round trip would be. I can say it doesn't break bemenu's width on sway.