Skip to content

coro: update for new linked list changes#99

Closed
erg wants to merge 1 commit intoCloudef:masterfrom
erg:fix-for-linked-lists
Closed

coro: update for new linked list changes#99
erg wants to merge 1 commit intoCloudef:masterfrom
erg:fix-for-linked-lists

Conversation

@erg
Copy link
Copy Markdown
Contributor

@erg erg commented Apr 11, 2025

zig version
0.15.0-dev.286+ddcf6fcdf

zig build test seems to pass without any errors.

I'm not a zig expert--Cursor did most of the work here. I tried to clean it up to a minimal patch, but you can use this as inspiration if you want to fix things a different way.

Great library!

@Cloudef
Copy link
Copy Markdown
Owner

Cloudef commented Apr 14, 2025

Thanks, the genericness of coro.sync.Queue should not be removed, but the changes look correct otherwise.

@erg erg force-pushed the fix-for-linked-lists branch from fc55a3c to fc30156 Compare April 15, 2025 02:41
@erg erg changed the title aio: update for new linked list changes coro: update for new linked list changes Apr 15, 2025
@erg erg force-pushed the fix-for-linked-lists branch from fc30156 to c2626d6 Compare April 15, 2025 02:43
@erg
Copy link
Copy Markdown
Contributor Author

erg commented Apr 15, 2025

I readded the coro generic. It might be good now!

edit: fixed the last T

zig version
0.15.0-dev.286+ddcf6fcdf
@erg erg force-pushed the fix-for-linked-lists branch from c2626d6 to bbc30e6 Compare April 15, 2025 02:46
@Cloudef
Copy link
Copy Markdown
Owner

Cloudef commented Apr 16, 2025

Thank you, I merged the code manually as I tested it.

@Cloudef Cloudef closed this Apr 16, 2025
@erg erg deleted the fix-for-linked-lists branch April 17, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants