fix: Delete output directory correctly when table name is used #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopengfoong
force-pushed
the
fix/55494-delete-directory-when-table-name-used
branch
from
a4200a4 to
f158e14
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the OpenMirroring Connector would fail to delete the correct output directory during archive operations when a custom table name was configured. The fix ensures that both export and archive operations use the same logic to determine the subdirectory path.
Changes:
- Extracted pattern replacement logic into a reusable
PatternHelperclass - Created
OutputDirectoryHelperto centralize subdirectory name calculation logic - Updated
ArchiveContainerto use the same subdirectory calculation as the export job
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Connector.FabricOpenMirroring/Connector/OutputDirectoryHelper.cs | New helper class to centralize subdirectory calculation logic, handling both table name patterns and default stream ID formatting |
| src/Connector.FabricOpenMirroring/Connector/OpenMirroringConnector.cs | Updated ArchiveContainer to use OutputDirectoryHelper for consistent subdirectory calculation |
| src/Connector.FabricOpenMirroring/Connector/OpenMirroringExportEntitiesJob.cs | Refactored to use OutputDirectoryHelper instead of inline logic |
| src/Connector.DataLake.Common/Connector/PatternHelper.cs | New helper class containing extracted pattern replacement logic for table/file name patterns |
| src/Connector.DataLake.Common/Connector/DataLakeExportEntitiesJobBase.cs | Removed pattern replacement methods (moved to PatternHelper), updated to use PatternHelper |
| src/Connector.OneLake/Connector/OneLakeExportEntitiesJob.cs | Updated to use PatternHelper.ReplaceNameUsingPatternAsync |
| test/integration/Connector.FabricOpenMirroring.Tests.Integration/FabricOpenMirroringConnectorTests.cs | Added tests for table name functionality and archive operations, reorganized imports |
| test/integration/Connector.DataLake.Common.Tests.Integration/DataLakeConnectorTestsBase.cs | Changed to use DeleteIfExistsAsync for more robust cleanup |
| docs/4.6.3-release-notes.md | Added release note documenting the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andrew-hardy
approved these changes
Jan 13, 2026
hopengfoong
deleted the
fix/55494-delete-directory-when-table-name-used
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Work Item ID: AB#55494
How has it been tested?
Release Note
Notable Changes