Skip to content

Conversation

@TaranDahl
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Feb 8, 2025

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@TaranDahl TaranDahl changed the title MP S&L MP S&L and AutoSave Feb 13, 2025
Copy link
Contributor

@ZivDero ZivDero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks okay, should work at a glance.

Copy link
Member

@Metadorius Metadorius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to my non-knowledgeable eye, I can only give a couple of minor nitpicks

@TaranDahl
Copy link
Contributor Author

Simply tested AutoSave in campaign mode, it saved correctly and generated loadable file. Will deal with the rest tomorrow.

@Metadorius
Copy link
Member

Sorry, haven't seen @ZivDero already reviewed it when reviewing xD

@TaranDahl
Copy link
Contributor Author

CnCNet/YRpp#2

@ZivDero
Copy link
Contributor

ZivDero commented Feb 14, 2025

CnCNet/YRpp#2

Merged

@Metadorius
Copy link
Member

Metadorius commented Feb 25, 2025

Tested it in Project Phantom with @Starkku, autosave appears to be working great, button too, was able to load a button-saved save from client without problems (however, at the moment only host can re-host the game).

In order to test (and adopt) this feature:

  1. Delete cncnet5.dll from the mod.
  2. Add the regular DLL from nightly build of this PR (can be found in the bot comment above) to the mod. In order to account for workarounds present in some newer versions of Syringe (which cause issues with YRpp spawner), DO NOT name it cncnet5.dll, leave the name like it is in the archive!
  3. Go to [mod directory]/Resources/ClientDefinitions.ini, ensure that you have those two settings set in the corresponding section:
[Settings]
DisableMultiplayerGameLoading=no
CreateSavedGamesDirectory=yes

By default, autosave is done each 7200 frames, and any player can manually trigger the save via options.
Loading ingame is not supported, but the host will be able to create a loaded game lobby, and the same users will be able to join. When all users join, the game can be started.

@Metadorius Metadorius merged commit b256465 into CnCNet:main Apr 11, 2025
3 checks passed
@TaranDahl TaranDahl deleted the MP_S&L branch April 21, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants