Skip to content

Fix invalid call to VirtualProtect #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Belonit merged 2 commits into from
Feb 20, 2025
Merged

Fix invalid call to VirtualProtect #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc50afc
Fix invalid call to VirtualProtect
shmocz Feb 10, 2025
9d2e836
Call FlushInstructionCache after patching
shmocz Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Utilities/Patch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ void Patch::Apply()
DWORD protect_flag;
VirtualProtect(pAddress, this->size, PAGE_EXECUTE_READWRITE, &protect_flag);
memcpy(pAddress, this->pData, this->size);
VirtualProtect(pAddress, this->size, protect_flag, NULL);
VirtualProtect(pAddress, this->size, protect_flag, &protect_flag);
// NOTE: Instruction cache flush isn't required on x86. This is just to conform with Win32 API docs.
FlushInstructionCache(GetCurrentProcess(), pAddress, this->size);
}

void Patch::Apply_LJMP(DWORD offset, DWORD pointer)
Expand Down