Skip to content

Conversation

@CoMPaTech
Copy link
Owner

@CoMPaTech CoMPaTech commented Jul 20, 2025

Summary by CodeRabbit

  • Chores
    • Improved workflow to prevent publishing packages if the version already exists on PyPI.
    • Streamlined version checking in verification workflow for efficiency.
    • Updated workflow permissions and refined package installation steps for better reliability.

@coderabbitai
Copy link

coderabbitai bot commented Jul 20, 2025

Walkthrough

The workflows for merging and verifying Python packages were updated. The merge workflow now checks if a package version exists on PyPI before publishing, installing the toml package for parsing version info. The verify workflow simplifies the check for existing versions on TestPyPI by streamlining the command pipeline for version matching.

Changes

Files/Paths Change Summary
.github/workflows/merge.yml Expanded permissions, removed explicit Python setup, installed toml, added PyPI version check, made build/publish conditional.
.github/workflows/verify.yml Simplified TestPyPI version existence check by combining retrieval and match into a single command.

Poem

A bunny hops through YAML fields,
With clever checks, a shield it wields—
No double-publish, no wasted run,
Streamlined scripts, oh what fun!
With toml in paw and curl in stride,
The package journey’s verified!
🐇✨

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch testing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🔭 Outside diff range comments (1)
.github/workflows/verify.yml (1)

175-193: Harden the “exists-already?” probe (404 handling, pipe safety, fixed-string grep).

  1. curl without -f will happily emit a 404 HTML body that jq cannot parse, producing noisy “parse error” lines.
  2. Because set -o pipefail isn’t enabled, the script ignores jq errors – you only get the grep exit-status.
  3. grep -q "^$PACKAGE_VERSION$" treats the version as a regex; versions such as 1.0.0b1+exp* will mis-match.

Diff sketch:

-if curl -s "https://test.pypi.org/pypi/$PACKAGE_NAME/json" | jq -r '.releases | keys[]' | grep -q "^$PACKAGE_VERSION$"; then
+set -euo pipefail
+if curl -fsSL "https://test.pypi.org/pypi/$PACKAGE_NAME/json" \
+     | jq -r '.releases // {} | keys[]' \
+     | grep -Fxq "$PACKAGE_VERSION"; then

This:

• fails fast on HTTP errors (-f)
• silences jq path-missing errors with // {}
• makes the pipeline fail on any sub-command (pipefail)
• uses fixed-string matching (-Fxq).

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b280b49 and ee8de00.

📒 Files selected for processing (2)
  • .github/workflows/merge.yml (1 hunks)
  • .github/workflows/verify.yml (1 hunks)
🔇 Additional comments (1)
.github/workflows/merge.yml (1)

27-33: Re-add an explicit Python toolchain – system default ≠ 3.13.

uv venv --seed venv seeds from whatever Python happens to be on the runner (currently 3.12 on ubuntu-latest).
Your DEFAULT_PYTHON: "3.13" is therefore ignored, and wheels built on an unintended interpreter may differ from local builds.

Add back the setup step:

- uses: actions/setup-python@v5
  with:
    python-version: ${{ env.DEFAULT_PYTHON }}

before creating the venv so that uv seeds the intended interpreter.

@CoMPaTech CoMPaTech merged commit f1ec171 into main Jul 20, 2025
9 checks passed
@CoMPaTech CoMPaTech deleted the testing branch July 20, 2025 07:12
@coderabbitai coderabbitai bot mentioned this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants