-
Notifications
You must be signed in to change notification settings - Fork 1
Unbreak workflows #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe workflows for merging and verifying Python packages were updated. The merge workflow now checks if a package version exists on PyPI before publishing, installing the Changes
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
.github/workflows/verify.yml (1)
175-193: Harden the “exists-already?” probe (404 handling, pipe safety, fixed-string grep).
curlwithout-fwill happily emit a 404 HTML body thatjqcannot parse, producing noisy “parse error” lines.- Because
set -o pipefailisn’t enabled, the script ignoresjqerrors – you only get thegrepexit-status.grep -q "^$PACKAGE_VERSION$"treats the version as a regex; versions such as1.0.0b1+exp*will mis-match.Diff sketch:
-if curl -s "https://test.pypi.org/pypi/$PACKAGE_NAME/json" | jq -r '.releases | keys[]' | grep -q "^$PACKAGE_VERSION$"; then +set -euo pipefail +if curl -fsSL "https://test.pypi.org/pypi/$PACKAGE_NAME/json" \ + | jq -r '.releases // {} | keys[]' \ + | grep -Fxq "$PACKAGE_VERSION"; thenThis:
• fails fast on HTTP errors (
-f)
• silences jq path-missing errors with// {}
• makes the pipeline fail on any sub-command (pipefail)
• uses fixed-string matching (-Fxq).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/merge.yml(1 hunks).github/workflows/verify.yml(1 hunks)
🔇 Additional comments (1)
.github/workflows/merge.yml (1)
27-33: Re-add an explicit Python toolchain – system default ≠ 3.13.
uv venv --seed venvseeds from whatever Python happens to be on the runner (currently 3.12 on ubuntu-latest).
YourDEFAULT_PYTHON: "3.13"is therefore ignored, and wheels built on an unintended interpreter may differ from local builds.Add back the setup step:
- uses: actions/setup-python@v5 with: python-version: ${{ env.DEFAULT_PYTHON }}before creating the venv so that
uvseeds the intended interpreter.
Summary by CodeRabbit